From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 15 Jul 2004 07:23:30 -0700 From: Tom Rini To: Olaf Hering Cc: Andrew Morton , linuxppc-dev@lists.linuxppc.org Subject: Re: [PATCH] fix missing option in binutils version check Message-ID: <20040715142329.GR21856@smtp.west.cox.net> References: <20040712180321.GB16877@smtp.west.cox.net> <20040713134945.GA5104@suse.de> <20040713140127.GJ16877@smtp.west.cox.net> <20040713140220.GA20213@suse.de> <20040713142015.GK16877@smtp.west.cox.net> <20040713151854.GA7858@suse.de> <20040713152633.GL16877@smtp.west.cox.net> <20040713152950.GB7858@suse.de> <20040714232336.GO21856@smtp.west.cox.net> <20040715125032.GA20266@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20040715125032.GA20266@suse.de> Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Thu, Jul 15, 2004 at 02:50:32PM +0200, Olaf Hering wrote: > On Wed, Jul 14, Tom Rini wrote: > > > > +BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o /dev/null 2>/dev/null 2>&1 && echo 0 || echo 1) > > > > -ifneq ($(NEW_AS),0) > > checkbin: > > +ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041) > > How is this supposed to work? You get either 0 or 1. There was a slight problem with the first patch. The following on top of it should fix things (lightly tested by making sure I could make it fail): diff -u edited/arch/ppc/Makefile edited/arch/ppc/Makefile --- edited/arch/ppc/Makefile 2004-07-14 16:22:58 -07:00 +++ edited/arch/ppc/Makefile 2004-07-15 07:20:40 -07:00 @@ -114,13 +114,14 @@ endif # gcc-3.4 and binutils-2.14 are a fatal combination. GCC_VERSION := $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) -BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o /dev/null 2>/dev/null 2>&1 && echo 0 || echo 1) +BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o /dev/null >/dev/null 2>&1 && echo 0 || echo 1) checkbin: ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041) - @echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no lonber build ' + @echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build ' @echo 'correctly with gcc-3.4 and your version of binutils.' @echo '*** Please upgrade your binutils or downgrade your gcc' + @false endif ifneq ($(NEW_AS),0) @echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build ' -- Tom Rini http://gate.crashing.org/~trini/ ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/