From: Tom Rini <trini@kernel.crashing.org>
To: Andreas Oberritter <obi@saftware.de>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] make platform_init() weak for 8xx
Date: Mon, 19 Jul 2004 09:32:03 -0700 [thread overview]
Message-ID: <20040719163203.GA6813@smtp.west.cox.net> (raw)
In-Reply-To: <1090253615.1415.24.camel@shiva.saftware.de>
On Mon, Jul 19, 2004 at 06:13:35PM +0200, Andreas Oberritter wrote:
> Hi Tom,
>
> this patch renames platform_init to m8xx_init in m8xx_setup.c and adds
> new weak platform_init, which can be overridden by boards to allow them
> to e.g. register platform_devices like redwood5.c does for 40x.
First, I don't see the redwood5 example you're talking about.
Second, this takes us in the direction of 82xx. Until the 82xx
abstractions get flushed out a bit more, I remain unconvinced that
they're really the right way to go (perhaps hooking the other direction
would work better, e.g. platform_init() calls board_init(), with a weak
version provided, and some functions forced to be provided by board.c,
such as m8xx_map_io).
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-19 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-19 16:13 [PATCH] make platform_init() weak for 8xx Andreas Oberritter
2004-07-19 16:32 ` Tom Rini [this message]
2004-07-19 17:34 ` Andreas Oberritter
2004-07-19 18:20 ` Tom Rini
2004-07-23 13:59 ` [PATCH] add board_init() (was [PATCH] make platform_init() weak for 8xx) Andreas Oberritter
2004-07-27 21:01 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040719163203.GA6813@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=obi@saftware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).