From: leigh@solinno.co.uk (Leigh Brown)
To: trini@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection
Date: Thu, 16 Sep 2004 19:25:31 +0100 [thread overview]
Message-ID: <20040916182531.GA20649@george.solinno.co.uk> (raw)
The ISA PIC address for acknowledging interrupts is actually defined
in residual data as a 32-bit system address, rather than a 32-bit
memory address. This is rather embarrasing, as I don't think this
function has done the right thing, ever.
Tested and working fine on my Carolina and 140.
Thanks,
Leigh.
Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
--- arch/ppc/platforms/residual.c.orig 2004-09-14 20:50:16.000000000 +0100
+++ arch/ppc/platforms/residual.c 2004-09-14 20:50:29.000000000 +0100
@@ -935,8 +935,8 @@
goto unknown;
#define p pkt->L4_Pack.L4_Data.L4_PPCPack
- /* Must be 32-bit memory address */
- if (!((p.PPCData[0] == 2) && (p.PPCData[1] == 32)))
+ /* Must be 32-bit system address */
+ if (!((p.PPCData[0] == 3) && (p.PPCData[1] == 32)))
goto unknown;
/* It doesn't seem to work where length != 1 (what can I say? :-/ ) */
next reply other threads:[~2004-09-16 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 18:25 Leigh Brown [this message]
2004-09-16 19:23 ` [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection Hollis Blanchard
2004-09-17 14:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916182531.GA20649@george.solinno.co.uk \
--to=leigh@solinno.co.uk \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).