* [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection
@ 2004-09-16 18:25 Leigh Brown
2004-09-16 19:23 ` Hollis Blanchard
0 siblings, 1 reply; 3+ messages in thread
From: Leigh Brown @ 2004-09-16 18:25 UTC (permalink / raw)
To: trini; +Cc: linuxppc-dev, paulus
The ISA PIC address for acknowledging interrupts is actually defined
in residual data as a 32-bit system address, rather than a 32-bit
memory address. This is rather embarrasing, as I don't think this
function has done the right thing, ever.
Tested and working fine on my Carolina and 140.
Thanks,
Leigh.
Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
--- arch/ppc/platforms/residual.c.orig 2004-09-14 20:50:16.000000000 +0100
+++ arch/ppc/platforms/residual.c 2004-09-14 20:50:29.000000000 +0100
@@ -935,8 +935,8 @@
goto unknown;
#define p pkt->L4_Pack.L4_Data.L4_PPCPack
- /* Must be 32-bit memory address */
- if (!((p.PPCData[0] == 2) && (p.PPCData[1] == 32)))
+ /* Must be 32-bit system address */
+ if (!((p.PPCData[0] == 3) && (p.PPCData[1] == 32)))
goto unknown;
/* It doesn't seem to work where length != 1 (what can I say? :-/ ) */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection
2004-09-16 18:25 [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection Leigh Brown
@ 2004-09-16 19:23 ` Hollis Blanchard
2004-09-17 14:46 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Hollis Blanchard @ 2004-09-16 19:23 UTC (permalink / raw)
To: Leigh Brown; +Cc: paulus, linuxppc-dev
On Sep 16, 2004, at 1:25 PM, Leigh Brown wrote:
> The ISA PIC address for acknowledging interrupts is actually defined
> in residual data as a 32-bit system address, rather than a 32-bit
> memory address. This is rather embarrasing, as I don't think this
> function has done the right thing, ever.
>
> Tested and working fine on my Carolina and 140.
And this is important, as 2.6.9-rcX suffer from the dreaded Carolina
"lost interrupt" problems. Could we try to get this patch into 2.6.9
final?
-Hollis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection
2004-09-16 19:23 ` Hollis Blanchard
@ 2004-09-17 14:46 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2004-09-17 14:46 UTC (permalink / raw)
To: Hollis Blanchard; +Cc: paulus, linuxppc-dev
On Thu, Sep 16, 2004 at 02:23:48PM -0500, Hollis Blanchard wrote:
> On Sep 16, 2004, at 1:25 PM, Leigh Brown wrote:
>
> >The ISA PIC address for acknowledging interrupts is actually defined
> >in residual data as a 32-bit system address, rather than a 32-bit
> >memory address. This is rather embarrasing, as I don't think this
> >function has done the right thing, ever.
> >
> >Tested and working fine on my Carolina and 140.
>
> And this is important, as 2.6.9-rcX suffer from the dreaded Carolina
> "lost interrupt" problems. Could we try to get this patch into 2.6.9
> final?
I'll try and get this in quickly.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-17 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-16 18:25 [PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection Leigh Brown
2004-09-16 19:23 ` Hollis Blanchard
2004-09-17 14:46 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).