Re: [PATCH] remove obsolete arch/ppc/8xx_io/uart.c

[Tom Rini <trini@kernel.crashing.org>]

On Thu, Oct 07, 2004 at 02:09:05PM -0400, Robert P. J. Day wrote:

> On Thu, 7 Oct 2004, Tom Rini wrote:
> 
> >Since these changes can go right into a linux-2.6 tree and out to 
> >Linus, I should be able to get BitKeeper to happily merge these 
> >changes and your changes.
> 
> since i already went to the trouble to figure out what it would take 
> to do this, i'll just post it in case any of it is helpful.
> 
> first, i assume that anything related to UARTs in arch/ppc/8xx_io/ can 
> be deleted (the newer stuff being in drivers/serial/cpm_uart/).  this 
> would include uart.c, and any references to UARTs in both Kconfig and 
> Makefile.  so that stuff is pretty easily deletable.

Right.

> regarding Kconfig, that currently defines the following config 
> variables related to UARTs (all of the latter ones dependent on the 
> first, so if you delete the first, all the rest pretty well have to 
> vanish as well):
> 
>   CONFIG_8xx_UART
>   CONFIG_SMC2_UART
>   CONFIG_ALTSMC2
>   CONFIG_CONS_SMC2
>   CONFIG_USE_SCC_IO

Not all of these options exist in linux-2.6.

> if you get rid of that chunk of Kconfig, then you better make sure 
> there's nothing in the rest of the kernel source that refers to any of 
> those config variables in any meaningful way.  other than uart.c, some 
> of these variables are listed in arch/ppc/configs/*, so you'd probably 
> want to clean up any of those defconfig files while you're at it.

Leaving them in the defconfigs is fine.  In fact, unless you're going to
properly convert them to the CPM_UART versions, it's best to leave them.

[snip]
>   apparently, according to this menu, i can walk through and select 
> every single serial port possibility: SMC[12] and SCC[1234].  but even 
> after you do that, you can apparently still go to the "MPC8xx" menu 
> and select to put ethernet on, say, SCC1.  i'm pretty sure you 
> shouldn't be able to select that SCC1 is for both UART and ethernet 
> simultaneously.  just need to add more dependencies to some Kconfig 
> files, i suspect.

I think this had been discussed before, but perhaps not.  What should
happen at some point is something more like "Do you hae SMC1 ? What is
it? Do you have SMC2 ? What is it? Do youhave SCC1? What is it?" and so
on.  For now, I wouldn't worry about it.

-- 
Tom Rini
http://gate.crashing.org/~trini/