From: Tom Rini <trini@kernel.crashing.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: "Nei A. Chiaradia" <nei.chiaradia@cyclades.com>,
Regina Kodato <regina.kodato@cyclades.com>,
Wanda Rosalino <wanda.rosalino@cyclades.com>,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] PRxK sub-architecture
Date: Fri, 15 Oct 2004 11:15:39 -0700 [thread overview]
Message-ID: <20041015181539.GG19791@smtp.west.cox.net> (raw)
In-Reply-To: <20041015160941.GA4054@logos.cnet>
[ Switched over to linuxppc-embedded ]
On Fri, Oct 15, 2004 at 01:09:41PM -0300, Marcelo Tosatti wrote:
Just some rough comments:
[snip]
> diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/8xx_io/fec.c linux-2.6-bkppc/arch/ppc/8xx_io/fec.c
> --- linux-2.6-bkppc.orig/arch/ppc/8xx_io/fec.c 2004-09-02 08:52:19.000000000 -0300
> +++ linux-2.6-bkppc/arch/ppc/8xx_io/fec.c 2004-09-02 14:33:23.000000000 -0300
> @@ -173,7 +173,7 @@
> uint phy_status;
> uint phy_speed;
> phy_info_t *phy;
> - struct tq_struct phy_task;
> + struct work_struct phy_task;
>
> uint sequence_done;
>
This looks like a dupe of what's already in linuxppc-2.5.
[snip]
> diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/boot/simple/embed_config.c linux-2.6-bkppc/arch/ppc/boot/simple/embed_config.c
> --- linux-2.6-bkppc.orig/arch/ppc/boot/simple/embed_config.c 2004-09-02 08:52:19.000000000 -0300
> +++ linux-2.6-bkppc/arch/ppc/boot/simple/embed_config.c 2004-09-02 10:17:19.000000000 -0300
This looks like it should be done in prxk.c, with the various hooks that
we provide in misc.c, which might have to be ported to misc-embedded.c.
[snip]
> diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/arch/ppc/boot/simple/head.S linux-2.6-bkppc/arch/ppc/boot/simple/head.S
> --- linux-2.6-bkppc.orig/arch/ppc/boot/simple/head.S 2004-09-02 08:52:19.000000000 -0300
> +++ linux-2.6-bkppc/arch/ppc/boot/simple/head.S 2004-09-02 17:30:39.000000000 -0300
Do we really need to do this? If so, why?
[snip]
> diff -Nur --exclude-from=/tmp/exclude linux-2.6-bkppc.orig/include/asm-ppc/prxk.h linux-2.6-bkppc/include/asm-ppc/prxk.h
> --- linux-2.6-bkppc.orig/include/asm-ppc/prxk.h 1969-12-31 21:00:00.000000000 -0300
> +++ linux-2.6-bkppc/include/asm-ppc/prxk.h 2004-09-02 08:54:51.000000000 -0300
[snip]
> +/* Machine type
> +*/
> +#define _MACH_8xx (_MACH_PRxK)
Eh? Is there more to come that moves 8xx towards what we have on
pmac/prep/chrp ? Or a left-over from older kernels?
Thanks.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-10-15 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 16:09 [PATCH] PRxK sub-architecture Marcelo Tosatti
2004-10-15 18:15 ` Tom Rini [this message]
2004-10-15 16:55 ` Marcelo Tosatti
2004-10-15 21:13 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041015181539.GG19791@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nei.chiaradia@cyclades.com \
--cc=regina.kodato@cyclades.com \
--cc=wanda.rosalino@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).