* [PATCH] write gas check tmp file to O= directory
@ 2004-10-24 16:09 Olaf Hering
2004-10-24 18:10 ` Tom Rini
2004-10-25 15:33 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Olaf Hering @ 2004-10-24 16:09 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
the tmp file should be in the O= directory.
btw, why does the mftb check not use '$?'?
diff -purN linux-2.6.9.orig/arch/ppc/Makefile linux-2.6.9-olh/arch/ppc/Makefile
--- linux-2.6.9.orig/arch/ppc/Makefile 2004-10-22 19:02:37.000000000 +0200
+++ linux-2.6.9-olh/arch/ppc/Makefile 2004-10-24 11:30:46.414921904 +0200
@@ -109,10 +109,10 @@ include/asm-$(ARCH)/offsets.h: arch/$(AR
TOUT := .tmp_gas_check
# Ensure this is binutils 2.12.1 (or 2.12.90.0.7) or later for altivec
# instructions.
-AS_ALTIVEC := $(shell echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; echo $$?)
+AS_ALTIVEC := $(shell echo dssall | $(AS) -many -o $(objdir)$(TOUT) >/dev/null 2>&1 ; echo $$?)
# gcc-3.4 and binutils-2.14 are a fatal combination.
GCC_VERSION := $(call cc-version)
-BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o $(TOUT) >/dev/null 2>&1 && echo 0 || echo 1)
+BAD_GCC_AS := $(shell echo mftb 5 | $(AS) -mppc -many -o $(objdir)$(TOUT) >/dev/null 2>&1 && echo 0 || echo 1)
checkbin:
ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041)
@@ -132,5 +132,5 @@ endif
CLEAN_FILES += include/asm-$(ARCH)/offsets.h \
arch/$(ARCH)/kernel/asm-offsets.s \
- $(TOUT)
+ $(objdir)$(TOUT)
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] write gas check tmp file to O= directory
2004-10-24 16:09 [PATCH] write gas check tmp file to O= directory Olaf Hering
@ 2004-10-24 18:10 ` Tom Rini
2004-10-25 15:33 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2004-10-24 18:10 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Sun, Oct 24, 2004 at 06:09:23PM +0200, Olaf Hering wrote:
> the tmp file should be in the O= directory.
[snip]
> @@ -132,5 +132,5 @@ endif
>
> CLEAN_FILES += include/asm-$(ARCH)/offsets.h \
> arch/$(ARCH)/kernel/asm-offsets.s \
> - $(TOUT)
> + $(objdir)$(TOUT)
Having to do this seems wrong. We don't need $(objdir) for any other
generated file in CLEAN_FILES.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] write gas check tmp file to O= directory
2004-10-24 16:09 [PATCH] write gas check tmp file to O= directory Olaf Hering
2004-10-24 18:10 ` Tom Rini
@ 2004-10-25 15:33 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2004-10-25 15:33 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Sun, Oct 24, 2004 at 06:09:23PM +0200, Olaf Hering wrote:
> the tmp file should be in the O= directory.
It is already. By changing AS_ALTIVEC to be just $(shell pwd) and
adding an echo to checkbin we see:
echo /home/trini/work/kernel/pristine/amit-kgdb/linux-2.6.9/lopec
So this isn't an issue.
>
> btw, why does the mftb check not use '$?'?
It was either that I saw different binutils fail with different exit
codes, or testing for 03041 looked better than '0304255' or whatever the
exit code was.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-25 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-24 16:09 [PATCH] write gas check tmp file to O= directory Olaf Hering
2004-10-24 18:10 ` Tom Rini
2004-10-25 15:33 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).