From: Colin Leroy <colin@colino.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "David S. Miller" <davem@redhat.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] sungem rework & wake on lan
Date: Fri, 26 Nov 2004 20:07:54 +0100 [thread overview]
Message-ID: <20041126200754.1123e8f8@jack.colino.net> (raw)
In-Reply-To: <1101439228.4633.74.camel@gaston>
On 26 Nov 2004 at 14h11, Benjamin Herrenschmidt wrote:
Hi Ben,
if (found_mii_phy(gp) && gp->phy_mii.def->ops->suspend)
- gp->phy_mii.def->ops->suspend(&gp->phy_mii, 0 /* wake on lan options */);
+ gp->phy_mii.def->ops->suspend(&gp->phy_mii);
Shouldn't this if() have an "&& !wol" clause ?
At least it doesn't work without it, and works with it, here on 5221 PHY.
Thanks for your work. Will post a patch applying to 2.6.9+sleep_patch soon
for the possibly interested people.
--
Colin
http://www.colino.net/
next prev parent reply other threads:[~2004-11-26 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-26 3:20 [PATCH] sungem rework & wake on lan Benjamin Herrenschmidt
2004-11-26 19:07 ` Colin Leroy [this message]
2004-11-26 22:03 ` Benjamin Herrenschmidt
2004-12-09 6:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041126200754.1123e8f8@jack.colino.net \
--to=colin@colino.net \
--cc=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).