From: Andrew Morton <akpm@osdl.org>
To: Kumar Gala <galak@linen.sps.mot.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][PPC32] Performance Monitor/Oprofile support for e500
Date: Tue, 30 Nov 2004 15:30:39 -0800 [thread overview]
Message-ID: <20041130153039.22b36348.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0411301517300.15307@linen.sps.mot.com>
Kumar Gala <galak@linen.sps.mot.com> wrote:
>
> Andrew,
>
> Adds oprofile support for the e500 PowerPC core.
- arch/ppc/kernel/perfmon_fsl_booke.c has prototypes for init_pmc_stop()
and friends, but those prototypes are already in
include/asm-ppc/perfmon.h
- please don't put prototypes and extern declarations in .c files. Ever.
It defeats typechecking. Put them in a header file which is visible to
all callers/users as well as to the implementation.
- Do these need to be exported to modules?
+EXPORT_SYMBOL(init_pmc_stop);
+EXPORT_SYMBOL(set_pmc_event);
+EXPORT_SYMBOL(set_pmc_user_kernel);
+EXPORT_SYMBOL(set_pmc_marked);
+EXPORT_SYMBOL(pmc_start_ctr);
+EXPORT_SYMBOL(pmc_start_ctrs);
+EXPORT_SYMBOL(pmc_stop_ctrs);
+EXPORT_SYMBOL(dump_pmcs);
and if so, does an EXPORT_SYMBOL_GPL() not suffice?
- This:
+extern void (*perf_irq)(struct pt_regs *);
should be in a header file.
I'll queue the patch up. Fixups relative to this patch would be
appreciated, thanks.
prev parent reply other threads:[~2004-11-30 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 21:21 [PATCH][PPC32] Performance Monitor/Oprofile support for e500 Kumar Gala
2004-11-30 23:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130153039.22b36348.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=galak@linen.sps.mot.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).