* [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
@ 2004-12-01 16:07 Gerhard Jaeger
2004-12-01 22:19 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Gerhard Jaeger @ 2004-12-01 16:07 UTC (permalink / raw)
To: linuxppc-embedded
Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when trying to
use bootp to get the IP parameters. It seems, that the patch only cures
the symptom but obviously not the cause ;)
Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig 2004-11-15 02:26:34.000000000 +0100
+++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c 2004-12-01 17:00:19.000000000 +0100
@@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
struct gfar_private *priv = netdev_priv(dev);
int result = 0;
+ if( !priv->mii_info->phyinfo )
+ return;
+
/* Delay to give the PHY a chance to change the
* register state */
msleep(1);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
2004-12-01 16:07 [PATCH][PPC32] Fix gianfar netdriver oops when using bootp Gerhard Jaeger
@ 2004-12-01 22:19 ` Kumar Gala
2004-12-02 8:07 ` Gerhard Jaeger
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2004-12-01 22:19 UTC (permalink / raw)
To: Gerhard Jaeger; +Cc: Embedded PPC Linux list
There is some belief that the following patch should fix the issue:
http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?=20
nav=3Dindex.html|ChangeSet@-3d
I would be interested to know if this helps w/o your patch.
- kumar
On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
> Hi,
>
> this patch fixes an issue, that occurs on my MPC8541CDS, when trying =
to
> use bootp to get the IP parameters. It seems, that the patch only =20
> cures
> the symptom but obviously not the cause ;)
>
> Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
>
> --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0 =
2004-11-15 =20
> 02:26:34.000000000 +0100
> +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01 =20
> 17:00:19.000000000 +0100
> @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv(dev);
> =A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
> =A0
> +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
> +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
> +
> =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to change the
> =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
> =A0=A0=A0=A0=A0=A0=A0 msleep(1);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
2004-12-01 22:19 ` Kumar Gala
@ 2004-12-02 8:07 ` Gerhard Jaeger
2004-12-02 8:14 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Gerhard Jaeger @ 2004-12-02 8:07 UTC (permalink / raw)
To: Kumar Gala; +Cc: Embedded PPC Linux list
Hi,
On Wednesday 01 December 2004 23:19, Kumar Gala wrote:
> There is some belief that the following patch should fix the issue:
>=20
> http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2? nav=3Dindex.html|=
ChangeSet@-3d
>=20
> I would be interested to know if this helps w/o your patch.
I'd like to cross-check this, but are you sure, you're referencing the corr=
ect
changeset? Currently I only got:
Error 500
Unable to find revision 1.2249.2.2
Gerhard
>=20
> - kumar
>=20
> On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
>=20
> > Hi,
> >
> > this patch fixes an issue, that occurs on my MPC8541CDS, when trying to
> > use bootp to get the IP parameters. It seems, that the patch only =20
> > cures
> > the symptom but obviously not the cause ;)
> >
> > Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
> >
> > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0 2004-11=
=2D15 =20
> > 02:26:34.000000000 +0100
> > +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01 =20
> > 17:00:19.000000000 +0100
> > @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> > =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv(dev);
> > =A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
> > =A0
> > +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
> > +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
> > +
> > =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to change the
> > =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
> > =A0=A0=A0=A0=A0=A0=A0 msleep(1);
>=20
>=20
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
2004-12-02 8:07 ` Gerhard Jaeger
@ 2004-12-02 8:14 ` Kumar Gala
2004-12-02 8:25 ` Gerhard Jaeger
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2004-12-02 8:14 UTC (permalink / raw)
To: Gerhard Jaeger; +Cc: Embedded PPC Linux list
Fun with mailers. Try this url:
http://tinyurl.com/6skww
- kumar
On Dec 2, 2004, at 2:07 AM, Gerhard Jaeger wrote:
> Hi,
>
> On Wednesday 01 December 2004 23:19, Kumar Gala wrote:
> > There is some belief that the following patch should fix the issue:
> >
> > http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?=20
> nav=3Dindex.html|ChangeSet@-3d
> >
> > I would be interested to know if this helps w/o your patch.
>
> I'd like to cross-check this, but are you sure, you're referencing the=20=
> correct
> changeset? Currently I only got:
> Error 500
> Unable to find revision 1.2249.2.2
>
> Gerhard
>
> >
> > - kumar
> >
> > On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
> >
> > > Hi,
> > >
> > > this patch fixes an issue, that occurs on my MPC8541CDS, when=20
> trying to
> > >=A0 use bootp to get the IP parameters. It seems, that the patch=20=
> only=A0
> > > cures
> > >=A0 the symptom but obviously not the cause ;)
> > >
> > > Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
> > >
> > > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0=20=
> 2004-11-15=A0
> > > 02:26:34.000000000 +0100
> > >=A0 +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01=A0
> > > 17:00:19.000000000 +0100
> > >=A0 @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> > >=A0 =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D =
netdev_priv(dev);
> > > =A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
> > >=A0 =A0
> > >=A0 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
> > >=A0 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
> > >=A0 +
> > >=A0 =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to =
change the
> > >=A0 =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
> > >=A0 =A0=A0=A0=A0=A0=A0=A0 msleep(1);
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
2004-12-02 8:14 ` Kumar Gala
@ 2004-12-02 8:25 ` Gerhard Jaeger
2004-12-03 10:46 ` Gerhard Jaeger
0 siblings, 1 reply; 6+ messages in thread
From: Gerhard Jaeger @ 2004-12-02 8:25 UTC (permalink / raw)
To: Kumar Gala; +Cc: Embedded PPC Linux list
On Thursday 02 December 2004 09:14, Kumar Gala wrote:
> Fun with mailers. Try this url:
>=20
> http://tinyurl.com/6skww
Thanks that works (I mean the URL ;)
I have not tested, but this might will work, as I noticed, that when addidi=
onally
CONFIG_RARP is enabled, there are also no problems.
Anyway, I'll test ASAP and will tell you the results.
Thanx so far,
Gerhard
>=20
> - kumar
>=20
> On Dec 2, 2004, at 2:07 AM, Gerhard Jaeger wrote:
>=20
> > Hi,
> >
> > On Wednesday 01 December 2004 23:19, Kumar Gala wrote:
> > > There is some belief that the following patch should fix the issue:
> > >
> > > http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?=20
> > nav=3Dindex.html|ChangeSet@-3d
> > >
> > > I would be interested to know if this helps w/o your patch.
> >
> > I'd like to cross-check this, but are you sure, you're referencing the=
=20
> > correct
> > changeset? Currently I only got:
> > Error 500
> > Unable to find revision 1.2249.2.2
> >
> > Gerhard
> >
> > >
> > > - kumar
> > >
> > > On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
> > >
> > > > Hi,
> > > >
> > > > this patch fixes an issue, that occurs on my MPC8541CDS, when=20
> > trying to
> > > >=A0 use bootp to get the IP parameters. It seems, that the patch=20
> > only=A0
> > > > cures
> > > >=A0 the symptom but obviously not the cause ;)
> > > >
> > > > Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
> > > >
> > > > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0=20
> > 2004-11-15=A0
> > > > 02:26:34.000000000 +0100
> > > >=A0 +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01=A0
> > > > 17:00:19.000000000 +0100
> > > >=A0 @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> > > >=A0 =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv=
(dev);
> > > > =A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
> > > >=A0 =A0
> > > >=A0 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
> > > >=A0 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
> > > >=A0 +
> > > >=A0 =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to chan=
ge the
> > > >=A0 =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
> > > >=A0 =A0=A0=A0=A0=A0=A0=A0 msleep(1);
> > >
> > >
>=20
>=20
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...
2004-12-02 8:25 ` Gerhard Jaeger
@ 2004-12-03 10:46 ` Gerhard Jaeger
0 siblings, 0 replies; 6+ messages in thread
From: Gerhard Jaeger @ 2004-12-03 10:46 UTC (permalink / raw)
To: Kumar Gala; +Cc: Embedded PPC Linux list
Hi,
On Thursday 02 December 2004 09:25, Gerhard Jaeger wrote:
> On Thursday 02 December 2004 09:14, Kumar Gala wrote:
> > Fun with mailers. Try this url:
> >
> > http://tinyurl.com/6skww
>
> Thanks that works (I mean the URL ;)
> I have not tested, but this might will work, as I noticed, that when
> addidionally CONFIG_RARP is enabled, there are also no problems.
>
> Anyway, I'll test ASAP and will tell you the results.
I've now applied this ipconfig patch and removed my piece of code and:
it works - so ignore my patch ;)
Thanx,
Gerhard
>
> Thanx so far,
> Gerhard
>
> > - kumar
> >
> > On Dec 2, 2004, at 2:07 AM, Gerhard Jaeger wrote:
> > > Hi,
> > >
> > > On Wednesday 01 December 2004 23:19, Kumar Gala wrote:
> > > > There is some belief that the following patch should fix the iss=
ue:
> > > >
> > > > http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?
> > >
> > > nav=3Dindex.html|ChangeSet@-3d
> > >
> > > > I would be interested to know if this helps w/o your patch.
> > >
> > > I'd like to cross-check this, but are you sure, you're referencing =
the
> > > correct
> > > changeset? Currently I only got:
> > > Error 500
> > > Unable to find revision 1.2249.2.2
> > >
> > > Gerhard
> > >
> > > > - kumar
> > > >
> > > > On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
> > > > > Hi,
> > > > >
> > > > > this patch fixes an issue, that occurs on my MPC8541CDS, when
> > >
> > > trying to
> > >
> > > > > use bootp to get the IP parameters. It seems, that the patch
> > >
> > > only=20
> > >
> > > > > cures
> > > > > the symptom but obviously not the cause ;)
> > > > >
> > > > > Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
> > > > >
> > > > > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig =20
> > >
> > > 2004-11-15=20
> > >
> > > > > 02:26:34.000000000 +0100
> > > > >
> > > > > +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c 2004-12-01=20
> > > > >
> > > > > 17:00:19.000000000 +0100
> > > > >
> > > > > @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> > > > > struct gfar_private *priv =3D netdev_priv(dev);
> > > > >
> > > > > int result =3D 0;
> > > > >
> > > > > =20
> > > > > + if( !priv->mii_info->phyinfo )
> > > > > + return;
> > > > > +
> > > > > /* Delay to give the PHY a chance to change the
> > > > > * register state */
> > > > >
> > > > > msleep(1);
--=20
Gerhard Jaeger g.jaeger@sysgo.com
SYSGO AG Embedded and Real-Time Software
www.sysgo.com | www.elinos.com | www.osek.de | www.imerva.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-12-03 11:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-01 16:07 [PATCH][PPC32] Fix gianfar netdriver oops when using bootp Gerhard Jaeger
2004-12-01 22:19 ` Kumar Gala
2004-12-02 8:07 ` Gerhard Jaeger
2004-12-02 8:14 ` Kumar Gala
2004-12-02 8:25 ` Gerhard Jaeger
2004-12-03 10:46 ` Gerhard Jaeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).