From: Christoph Hellwig <hch@lst.de>
To: Jim Nelson <james4765@cwazy.co.uk>
Cc: linuxppc-dev@ozlabs.org, Brian Gerst <bgerst@didntduck.org>,
paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] ppc: remove cli()/sti() from arch/ppc/*
Date: Wed, 5 Jan 2005 10:26:59 +0100 [thread overview]
Message-ID: <20050105092659.GA27103@lst.de> (raw)
In-Reply-To: <41DB5476.9040103@cwazy.co.uk>
On Tue, Jan 04, 2005 at 09:44:06PM -0500, Jim Nelson wrote:
> Brian Gerst wrote:
>
> >James Nelson wrote:
> >
> >>This series of patches is to remove the last cli()/sti() function
> >>calls in arch/ppc.
> >>
> >>These are the only instances in active code that grep could find.
> >
> >
> >Are you sure none of these need real spinlocks instead of just
> >disabling interrupts?
> >
> >--
> > Brian Gerst
> >
> These are for single-processor systems, mostly evaluation boards and
> embedded processors. I coudn't find any reference to multiprocessor
> setups for the processors in question after a peruse of the code or a
> quick google on the boards in question.
think CONFIG_PREEMPT. In either case a spinlock becomes
lock_irq_disable in the !SMP, !PREEMPT case but it documents the
intention a whole lot better.
Also you're locking only in a single plpace which is a ***BIG*** warning
sign. At least look at the other users of the data structure, it's
extremly likely they'll need locking aswell.
next prev parent reply other threads:[~2005-01-05 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050104214048.21749.85722.89116@localhost.localdomain>
2005-01-05 2:19 ` [PATCH 0/7] ppc: remove cli()/sti() from arch/ppc/* Brian Gerst
2005-01-05 2:44 ` Jim Nelson
2005-01-05 9:26 ` Christoph Hellwig [this message]
2005-01-05 11:19 ` Jim Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050105092659.GA27103@lst.de \
--to=hch@lst.de \
--cc=bgerst@didntduck.org \
--cc=james4765@cwazy.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).