From: Christoph Hellwig <hch@lst.de>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: linuxppc64-dev@ozlabs.org, linuxppc-dev@ozlabs.org
Subject: Re: U3 G5 AGP support patch (v4)
Date: Sun, 9 Jan 2005 17:06:14 +0100 [thread overview]
Message-ID: <20050109160614.GA22839@lst.de> (raw)
In-Reply-To: <4240b916050109072621440269@mail.gmail.com>
+static struct device_node* uninorth_node __pmacdata;
+static u32 __iomem * uninorth_base __pmacdata;
static struct device_node *uninorth_node __pmacdata;
static u32 __iomem *uninorth_base __pmacdata;
+ if(uninorth_rev == 0x21) {
if (uninorth_rev == 0x21) {
+ if((uninorth_rev >= 0x30) && (uninorth_rev <= 0x33)) {
if ((uninorth_rev >= 0x30) && (uninorth_rev <= 0x33)) {
+ if (agp_bridge->dev->device == PCI_DEVICE_ID_APPLE_U3_AGP) {
+ /* This is an AGP V3 */
+ agp_device_command(command, TRUE);
+ } else {
+ /* AGP V2 */
+ agp_device_command(command, FALSE);
+ }
double-indentation, also please use 1/0 instead of TRUE/FALSE.
+static struct aper_size_info_32 u3_sizes[8] =
+{
+/*
+ * Not sure that uninorth3 supports that high aperture sizes but it
+ * would strange if it did not :)
+ */
comment before the struct declearation, please, aka
/*
* Not sure that uninorth3 supports that high aperture sizes but it
* would strange if it did not :)
*/
static struct aper_size_info_32 u3_sizes[8] = {
+ uninorth_node = of_find_node_by_name(NULL, "uni-n");
+ /* Locate G5 u3 */
+ if (uninorth_node == NULL) {
+ uninorth_node = of_find_node_by_name(NULL, "u3");
+ }
/* Locate G5 u3 */
uninorth_node = of_find_node_by_name(NULL, "uni-n");
if (!uninorth_node)
uninorth_node = of_find_node_by_name(NULL, "u3");
+ /*
+ * Set specific functions & values for agp3 controller.
+ */
+ if (pdev->device == PCI_DEVICE_ID_APPLE_U3_AGP) {
+ uninorth_agp_driver.insert_memory = uninorth3_insert_memory;
+ uninorth_agp_driver.aperture_sizes = (void *)u3_sizes;
+ uninorth_agp_driver.num_aperture_sizes = 8;
Please delcare separate driver instance instead of overriding.
And asm-ppc64 is still missing an agp.h, no?
next prev parent reply other threads:[~2005-01-09 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 15:26 U3 G5 AGP support patch (v4) Jerome Glisse
2005-01-09 16:06 ` Christoph Hellwig [this message]
2005-01-09 17:46 ` Jerome Glisse
2005-01-09 20:41 ` Jerome Glisse
2005-01-10 18:16 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050109160614.GA22839@lst.de \
--to=hch@lst.de \
--cc=j.glisse@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).