linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Ho Lee" <flylist@linuxkernel.net>
To: "'linuxppc'" <linuxppc-embedded@ozlabs.org>
Cc: 'Steffen Rumler' <Steffen.Rumler@siemens.com>
Subject: RE: Kernel boot hangs by parallel flood pings
Date: Wed, 12 Jan 2005 16:14:49 -0800	[thread overview]
Message-ID: <200501130009.j0D09vra020125@sarang.flyduck.com> (raw)
In-Reply-To: <F9865C8B04ED3A4D8D793FCE19368854F2FBDF@EXCHANGE01.corp.skystream.com>


I met the same problem in CPM driver, and there could be many 
solutions. I think the right place to fix is the fec driver. 
The fec driver registers interrupt handler during the 
initialization not when the device is opened, so it may
receive packets even the device is not up and running (also 
before the network subsystem is initialized) My fix was to 
ignore the received packets if the driver is not opened. 

--- linux-2.4.26.orig/arch/ppc/8xx_io/fec.c
+++ linux-2.4.26/arch/ppc/8xx_io/fec.c 
@@ -587,6 +587,9 @@
                goto rx_processing_done;
        }
 
+       if (!netif_running(dev))
+           goto rx_processing_done;
+
        /* Process the incoming frame.
         */
        fep->stats.rx_packets++;


Regards,
Ho

-----Original Message-----
From: linuxppc-embedded-bounces@ozlabs.org
[mailto:linuxppc-embedded-bounces@ozlabs.org] On Behalf Of Rune Torgersen
Sent: Wednesday, January 12, 2005 7:32 AM
To: Steffen Rumler; linuxppc
Subject: RE: Kernel boot hangs by parallel flood pings

--- Kernel.old/net/ipv4/ip_output.c     Thu Jun  5 09:00:39 2003
+++ Kernel/net/ipv4/ip_output.c Thu Jun  5 09:00:28 2003
@@ -1087,11 +1087,11 @@

 void __init ip_init(void)
 {
-       dev_add_pack(&ip_packet_type);
-
        ip_rt_init();
        inet_initpeers();

+       dev_add_pack(&ip_packet_type);
+
 #ifdef CONFIG_IP_MULTICAST
        proc_net_create("igmp", 0, ip_mc_procinfo);
 #endif
>>

       reply	other threads:[~2005-01-13  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <F9865C8B04ED3A4D8D793FCE19368854F2FBDF@EXCHANGE01.corp.skystream.com>
2005-01-13  0:14 ` Ho Lee [this message]
2005-01-19 18:30 Kernel boot hangs by parallel flood pings Johns Daniel
  -- strict thread matches above, loose matches on Subject: below --
2005-01-12 15:32 Rune Torgersen
2005-01-12 16:10 ` Wolfgang Denk
2005-01-12  8:38 Steffen Rumler
2005-01-12 10:29 ` Stefan Nickl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501130009.j0D09vra020125@sarang.flyduck.com \
    --to=flylist@linuxkernel.net \
    --cc=Steffen.Rumler@siemens.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).