Re: [PATCH] oprofile: falling back on timer interrupt mode

Re: [PATCH] oprofile: falling back on timer interrupt mode

[Olaf Hering]

 On Wed, Jan 26, Linux Kernel Mailing List wrote:

> ChangeSet 1.2038, 2005/01/25 20:31:01-08:00, amgta@yacht.ocn.ne.jp
> 
> 	[PATCH] oprofile: falling back on timer interrupt mode

> 
>  arch/alpha/oprofile/common.c     |    6 ++++--
>  arch/arm/oprofile/common.c       |    7 +++++--
>  arch/arm/oprofile/init.c         |    8 ++++++--
>  arch/i386/oprofile/init.c        |    4 +++-
>  arch/ia64/oprofile/init.c        |    8 ++++++--
>  arch/m32r/oprofile/init.c        |    3 ++-
>  arch/parisc/oprofile/init.c      |    3 ++-
>  arch/ppc64/oprofile/common.c     |    6 ++++--
>  arch/s390/oprofile/init.c        |    3 ++-
>  arch/sh/oprofile/op_model_null.c |    3 ++-
>  arch/sparc64/oprofile/init.c     |    3 ++-
>  drivers/oprofile/oprof.c         |    6 +++---
>  include/linux/oprofile.h         |    2 +-
>  13 files changed, 42 insertions(+), 20 deletions(-)

This misses arch/ppc

Re: [PATCH] oprofile: falling back on timer interrupt mode

[Akinobu Mita]

On Thursday 27 January 2005 04:05, Olaf Hering wrote:
>  On Wed, Jan 26, Linux Kernel Mailing List wrote:
> > ChangeSet 1.2038, 2005/01/25 20:31:01-08:00, amgta@yacht.ocn.ne.jp
> >
> > 	[PATCH] oprofile: falling back on timer interrupt mode

> This misses arch/ppc


Thanks for pointing that out.

This is opofile timer-mode fallback fix for ppc.

Signed-off-by: Akinobu Mita <amgta@yacht.ocn.ne.jp>

--- 2.6-bk/arch/ppc/oprofile/common.c.orig	2005-01-27 23:28:44.000000000 +0900
+++ 2.6-bk/arch/ppc/oprofile/common.c	2005-01-27 23:32:27.000000000 +0900
@@ -124,7 +124,7 @@ static struct oprofile_operations oprof_
 	.cpu_type	= NULL		/* To be filled in below. */
 };
 
-void __init oprofile_arch_init(struct oprofile_operations *ops)
+int __init oprofile_arch_init(struct oprofile_operations *ops)
 {
 	char *name;
 	int cpu_id = smp_processor_id();
@@ -132,14 +132,13 @@ void __init oprofile_arch_init(struct op
 #ifdef CONFIG_FSL_BOOKE
 	model = &op_model_fsl_booke;
 #else
-	printk(KERN_ERR "oprofile enabled on unsupported processor!\n");
-	return;
+	return -ENODEV;
 #endif
 
 	name = kmalloc(32, GFP_KERNEL);
 
 	if (NULL == name)
-		return;
+		return -ENOMEM;
 
 	sprintf(name, "ppc/%s", cur_cpu_spec[cpu_id]->cpu_name);
 
@@ -151,6 +150,8 @@ void __init oprofile_arch_init(struct op
 
 	printk(KERN_INFO "oprofile: using %s performance monitoring.\n",
 	       oprof_ppc32_ops.cpu_type);
+
+	return 0;
 }
 
 void oprofile_arch_exit(void)