From: olof@austin.ibm.com (Olof Johansson)
To: Arnd Bergmann <arnd@arndb.de>
Cc: akpm@osdl.org, trini@kernel.crashing.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
paulus@samba.org, hpa@zytor.com, linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro
Date: Fri, 4 Feb 2005 12:35:14 -0600 [thread overview]
Message-ID: <20050204183514.GB17586@austin.ibm.com> (raw)
In-Reply-To: <200502041336.59892.arnd@arndb.de>
On Fri, Feb 04, 2005 at 01:36:55PM +0100, Arnd Bergmann wrote:
> I have a somewhat similar patch that does the same to the
> systemcfg->platform checks. I'm not sure if we should use the same inline
> function for both checks, but I do think that they should be used in a
> similar way, e.g. CPU_HAS_FEATURE(x) and PLATFORM_HAS_FEATURE(x).
Yep. Firmware features are also on the list. I figured I'd do CPU features
first though since they are the ones that started bugging me.
> The same stuff is obviously possible for cur_cpu_spec->cpu_features as well.
> Do you think that it will help there?
Nice. It won't be quite as easy to do compile-time for cpu features.
pSeries will need all cpus enabled since we have them all on various
machines, etc. I guess Powermac/Maple could benefit from it. In the
end it depends on how hairy the implementation would get vs performance
improvement.
-Olof
next prev parent reply other threads:[~2005-02-04 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 7:22 [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro Olof Johansson
2005-02-04 8:17 ` Pekka Enberg
2005-02-04 17:20 ` Olof Johansson
2005-02-05 7:48 ` Pekka Enberg
2005-02-05 9:08 ` Benjamin Herrenschmidt
2005-02-04 12:36 ` Arnd Bergmann
2005-02-04 18:35 ` Olof Johansson [this message]
2005-02-04 18:57 ` Arnd Bergmann
2005-02-04 23:50 ` Benjamin Herrenschmidt
2005-02-04 23:49 ` Benjamin Herrenschmidt
2005-02-05 0:22 ` Arnd Bergmann
2005-02-05 1:34 ` Anton Blanchard
2005-02-05 11:04 ` Arnd Bergmann
2005-02-05 1:47 ` Benjamin Herrenschmidt
2005-02-04 14:45 ` Tom Rini
2005-02-05 18:46 ` [PATCH] PPC/PPC64: Abstract cpu_feature checks Olof Johansson
2005-02-06 3:26 ` Olof Johansson
2005-02-06 11:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050204183514.GB17586@austin.ibm.com \
--to=olof@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).