From: Eugene Surovegin <ebs@ebshome.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: [PATCH][PPC32] PPC4xx PIC: ack parent UIC in disable_irq
Date: Fri, 18 Feb 2005 12:38:36 -0800 [thread overview]
Message-ID: <20050218203836.GB18041@gate.ebshome.net> (raw)
In-Reply-To: <20050218203455.GA18041@gate.ebshome.net>
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
Andrew,
this patch fixes bug in PPC4xx disable_irq implementation. We need to
ACK parent UIC to prevent false triggering in case IRQ we just
disabled was already pending.
Signed-off-by: Eugene Surovegin <ebs@ebshome.net>
[-- Attachment #2: ppc4xx_pic_disable_irq_ack_parent.diff --]
[-- Type: text/plain, Size: 793 bytes --]
diff -Nru a/arch/ppc/syslib/ppc4xx_pic.c b/arch/ppc/syslib/ppc4xx_pic.c
--- a/arch/ppc/syslib/ppc4xx_pic.c 2005-02-18 12:12:54 -08:00
+++ b/arch/ppc/syslib/ppc4xx_pic.c 2005-02-18 12:12:54 -08:00
@@ -4,7 +4,7 @@
* Interrupt controller driver for PowerPC 4xx-based processors.
*
* Eugene Surovegin <eugene.surovegin@zultys.com> or <ebs@ebshome.net>
- * Copyright (c) 2004 Zultys Technologies
+ * Copyright (c) 2004, 2005 Zultys Technologies
*
* Based on original code by
* Copyright (c) 1999 Grant Erickson <grant@lcse.umn.edu>
@@ -49,6 +49,7 @@
{ \
ppc_cached_irq_mask[n] &= ~IRQ_MASK_UIC##n(irq); \
mtdcr(DCRN_UIC_ER(UIC##n), ppc_cached_irq_mask[n]); \
+ ACK_UIC##n##_PARENT \
} \
\
static void ppc4xx_uic##n##_ack(unsigned int irq) \
prev parent reply other threads:[~2005-02-18 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 20:34 [PATCH][PPC32] Lindentify PPC4xx PIC driver Eugene Surovegin
2005-02-18 20:38 ` Eugene Surovegin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050218203836.GB18041@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=akpm@osdl.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).