Re: mv64x60 updates

[Sven Luther <sven.luther@wanadoo.fr>]

On Mon, Mar 07, 2005 at 12:30:19PM +0000, James Chapman wrote:
> Hi Nicolas,
> 
> A few general comments:-
> 
> - mv64x60 stuff is best posted to linuxppc-embedded

The pegasos is not an embedded machine though, but i guess it is on -embedded
where the people using it are.

> - you change several generic files to support your platform. It should
>   be possible to support new mv64x60 platforms by writing a new
>   xxx_setup.c file in arch/ppc/platforms with no other generic changes.

Well, the pegasos is a chrp, so most of the stuff is in chrp_setup.c already.

>   It is a goal that all mv64x60 boards can be supported by the generic
>   code in arch/ppc/syslib. If some changes need to be made outside

I don't think this is sane. The generic mv64x60 stuff is for embedded boards, 
and does initialize too much stuff for the pegasos. At least in the current
state of it, which is why i asked about Mark's comments about our case.

>   arch/ppc/platforms to support your board, try to make them generic so
>   that other similar boards would be able to use them. I suggest you
>   clone chrp_setup.c or katana.c rather than adding conditionals in

Why ? The pegasos is a chrp, and it works perfectly with the chrp_setup stuff,
we just need to add the necessary code for making use of the gige interface of
the marvell, the rest works perfectly in chrp.

>   chrp_setup.c for your board. Then use code in your board specific
>   setup file to call arch/ppc/syslib mv64x60 routines as appropriate.

Yep.

> - you shouldn't need to add board-specific changes in mv643xx_eth.c.
>   Setup device platform data for your board in your platform file.
>   If something needs to be added to the platform data for a generic
>   change to mv643xx_eth, do that rather than add platform conditionals
>   in the driver.

Ok.

> - why do you need to use SA_SHIRQ in the ethernet driver?

I think because the two ports share the irq with other devices, not sure
though.

Friendly,

Sven Luther