From: Eugene Surovegin <ebs@ebshome.net>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 3/3] PPC440EP IBM EMAC support
Date: Tue, 15 Mar 2005 11:22:16 -0800 [thread overview]
Message-ID: <20050315192216.GB18588@gate.ebshome.net> (raw)
In-Reply-To: <1110913134.24673.32.camel@rhino.az.mvista.com>
On Tue, Mar 15, 2005 at 11:58:54AM -0700, Wade Farnsworth wrote:
> This patch adds support to the IBM EMAC ethernet driver for the 440EP.
>
> Regards,
> Wade Farnsworth
>
> Signed-off-by: Wade Farnsworth <wfarnsworth@mvista.com>
>
> --- linux-2.6.11-bk7/drivers/net/ibm_emac/ibm_emac_phy.c 2005-03-02 00:38:13.000000000 -0700
> +++ linux-2.6.11-bk7-440ep/drivers/net/ibm_emac/ibm_emac_phy.c 2005-03-11 16:32:01.000000000 -0700
> @@ -27,6 +27,12 @@
>
> #include "ibm_emac_phy.h"
>
> +#ifdef CONFIG_BAMBOO
> +#define BAMBOO_REV0 (mfspr(PVR) == PVR_440EP_RA)
> +#else
> +#define BAMBOO_REV0 0
> +#endif
> +
I really don't like it. Chip revision doesn't imply which board
this code is running on. Please, think of some other way to do this or
drop this completely.
--
Eugene
next prev parent reply other threads:[~2005-03-15 19:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 17:17 [PATCH 1/3] PPC440EP SoC and Bamboo board support Wade Farnsworth
2005-03-15 18:41 ` Eugene Surovegin
2005-03-15 19:08 ` Wade Farnsworth
2005-03-15 20:58 ` Jason McMullan
2005-03-15 21:38 ` Wade Farnsworth
2005-03-15 18:47 ` [PATCH 2/3] PPC440EP: ibm_emac phy mode bug fix Wade Farnsworth
2005-03-15 18:58 ` [PATCH 3/3] PPC440EP IBM EMAC support Wade Farnsworth
2005-03-15 19:22 ` Eugene Surovegin [this message]
2005-03-15 19:24 ` Eugene Surovegin
2005-03-15 20:43 ` Matt Porter
2005-03-15 20:37 ` Matt Porter
2005-03-28 17:52 ` Wade Farnsworth
2005-03-15 19:31 ` 440EP FPU patch McMullan, Jason
2005-03-15 20:50 ` Matt Porter
2005-03-15 21:09 ` Kumar Gala
2005-03-15 22:18 ` Jason McMullan
2005-03-16 7:22 ` Kumar Gala
2005-03-16 22:14 ` Tom Rini
2005-03-16 22:52 ` Kumar Gala
2005-03-16 23:18 ` Tom Rini
2005-03-18 16:06 ` Kumar Gala
2005-03-18 18:43 ` Jason McMullan
2005-03-18 19:30 ` Tom Rini
2005-03-31 16:26 ` Wade Farnsworth
2005-03-31 16:34 ` Tom Rini
2005-03-31 18:45 ` Kumar Gala
2005-03-31 19:04 ` Tom Rini
2005-03-31 20:10 ` Matt
2005-03-31 20:15 ` Tom Rini
2005-03-31 23:10 ` Kumar Gala
2005-03-31 23:37 ` Josh Boyer
2005-03-16 1:43 ` [PATCH 1/3] PPC440EP SoC and Bamboo board support Josh Boyer
2005-03-16 16:09 ` Wade Farnsworth
2005-03-16 17:26 ` Jason McMullan
2005-03-16 18:04 ` Wade Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315192216.GB18588@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).