From: Colin Leroy <colin@colino.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Linux-USB <linux-usb-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Make sleep/wakeup work with USB on powerbooks
Date: Thu, 17 Mar 2005 15:20:39 +0100 [thread overview]
Message-ID: <20050317152039.0b9d9fde@jack.colino.net> (raw)
In-Reply-To: <1111044955.7192.210.camel@gaston>
On 17 Mar 2005 at 18h03, Benjamin Herrenschmidt wrote:
Hi,
> > Would it be the "proper" patch I was looking for in the thread named
> > "[PATCH] Re-power USB ports on wakeup" ?
> >
> > Or does it fix different issues ? Mine fixed, with a hack I think,
> > the fact that USB ports kept being powered down after one wakeup
> > out of two. I never got any machine check, however.
>
> Test please, your patch shouldn't be necessary.
Just did so, it's not enough. My patch seems necessary so that usb
ports are powered at each wakeup (the second one, that doesn't touch
anything at sleep and sets power unconditionnaly at wakeup, works fine).
With Paul's patch, (dis)connecting USB devices during sleep isn't a
problem anymore.
--
Colin
next prev parent reply other threads:[~2005-03-17 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 5:36 [PATCH] Make sleep/wakeup work with USB on powerbooks Paul Mackerras
2005-03-17 6:51 ` Colin Leroy
2005-03-17 7:35 ` Benjamin Herrenschmidt
2005-03-17 14:20 ` Colin Leroy [this message]
2005-03-17 18:47 ` [linux-usb-devel] " Alan Stern
2005-03-17 18:58 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050317152039.0b9d9fde@jack.colino.net \
--to=colin@colino.net \
--cc=benh@kernel.crashing.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).