linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc32/64: Map prefetchable PCI without guarded bit
Date: Thu, 24 Mar 2005 08:54:45 -0800	[thread overview]
Message-ID: <200503240854.45741.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1111645464.5569.15.camel@gaston>

On Wednesday, March 23, 2005 10:24 pm, Benjamin Herrenschmidt wrote:
> While experimenting with framebuffer access performances, we noticed a
> very significant improvement in write access to it when not setting
> the "guarded" bit on the MMU mappings. This bit basically says that
> reads and writes won't have side effects (it allows speculation). It
> appears that it also disables write combining.

Doesn't pgprot_writecombine imply non-guarded, so can't you use it instead?  
Either way, you'll probably want to fix fbmem.c as well and turn off 
_PAGE_GUARDED?

Maybe it's time for a more generic call to support this stuff, both for 
in-kernel mappings and ones that we export to userspace.

Jesse

  reply	other threads:[~2005-03-25  6:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-24  6:24 [PATCH] ppc32/64: Map prefetchable PCI without guarded bit Benjamin Herrenschmidt
2005-03-24 16:54 ` Jesse Barnes [this message]
2005-03-24 16:55   ` Jesse Barnes
2005-03-25 22:23   ` Benjamin Herrenschmidt
2005-03-24 18:20 ` Segher Boessenkool
2005-03-25 22:26   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503240854.45741.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).