From: Eugene Surovegin <ebs@ebshome.net>
To: Kumar Gala <galak@freescale.com>
Cc: Andrew Morton <akpm@osdl.org>,
shall@mvista.com, linux-kernel@vger.kernel.org,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] ppc32: CPM2 PIC cleanup
Date: Tue, 29 Mar 2005 12:12:09 -0800 [thread overview]
Message-ID: <20050329201209.GB30850@gate.ebshome.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0503291039180.15390@blarg.somerset.sps.mot.com>
On Tue, Mar 29, 2005 at 10:42:29AM -0600, Kumar Gala wrote:
> Andrew,
>
> Cleaned up the CPM2 interrupt controller code:
> * Added the ability to offset the IRQs
> * Refactored common PIC init code out of platform files
> * Fixed IRQ offsets on MPC85xx so it can handle properly handled multiple
> interrupt controllers (i8259, CPM2 PIC, and OpenPIC)
>
> Signed-off-by: Jason McMullan <jason.mcmullan@timesys.com>
> Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
>
[snip]
Guys, while you are at it, could we renumber irq_to_siubit[] array in
cpm2_pic.c so we can get rid of "1 << (31 - bit)" expressions and
simply use "1 << bit"? I know, it's a minor thing, but you are
cleaning this stuff anyway, why not make it super clean :).
--
Eugene
next prev parent reply other threads:[~2005-03-29 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 16:42 [PATCH] ppc32: CPM2 PIC cleanup Kumar Gala
2005-03-29 20:12 ` Eugene Surovegin [this message]
2005-03-29 22:30 ` [PATCH] ppc32: CPM2 PIC cleanup irq_to_siubit array Kumar Gala
2005-03-30 1:10 ` Dan Malek
2005-03-30 4:20 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050329201209.GB30850@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=akpm@osdl.org \
--cc=galak@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=shall@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).