From: Eugene Surovegin <ebs@ebshome.net>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 2.6.10-rc2] ppc32: Add usb support to IBM stb04xxx platforms
Date: Thu, 31 Mar 2005 13:08:07 -0800 [thread overview]
Message-ID: <20050331210806.GA5694@gate.ebshome.net> (raw)
In-Reply-To: <20050331204729.GA29785@xyzzy>
On Thu, Mar 31, 2005 at 01:47:30PM -0700, Dale Farnsworth wrote:
[snip]
> ===================================================================
> --- linux-2.5-usb-405.orig/arch/ppc/platforms/4xx/redwood5.c
> +++ linux-2.5-usb-405/arch/ppc/platforms/4xx/redwood5.c
> @@ -52,8 +52,18 @@
> void __init
> redwood5_setup_arch(void)
> {
> + u32 mask;
> +
> ppc4xx_setup_arch();
>
> + /*
> + * Set up USB interrupt as positive polarity and level-sensitive.
> + * Firmware should do this, but apparently does not.
> + */
> + mask = 1 << (31 - USB0_IRQ);
> + mtdcr(DCRN_UIC_PR(UIC0), mfdcr(DCRN_UIC_PR(UIC0)) | mask);
> + mtdcr(DCRN_UIC_TR(UIC0), mfdcr(DCRN_UIC_TR(UIC0)) & ~mask);
> +
> #ifdef CONFIG_DEBUG_BRINGUP
> printk("\n");
> printk("machine\t: %s\n", PPC4xx_MACHINE_NAME);
Dale, please, don't mess with UIC registers directly, there is a
cleaner way to set this up.
Take a look at how this is done in other 4xx ports
(ppc4xx_core_uic_cfg & ppc4xx_uic_ext_irq_cfg).
--
Eugene
next prev parent reply other threads:[~2005-03-31 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 20:47 [PATCH 2.6.10-rc2] ppc32: Add usb support to IBM stb04xxx platforms Dale Farnsworth
2005-03-31 21:08 ` Eugene Surovegin [this message]
2005-03-31 23:31 ` Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331210806.GA5694@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=dale@farnsworth.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).