From: Eugene Surovegin <ebs@ebshome.net>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org
Subject: Re: {PATCH] Fix IBM EMAC driver ioctl bug
Date: Thu, 14 Apr 2005 21:01:12 -0700 [thread overview]
Message-ID: <20050415040112.GB11362@gate.ebshome.net> (raw)
In-Reply-To: <425EB470.9040203@am.sony.com>
On Thu, Apr 14, 2005 at 11:20:32AM -0700, Geoff Levand wrote:
> Fix IBM EMAC driver ioctl bug.
>
> I found IBM EMAC driver bug.
> So mii-tool command print wrong status.
>
> # mii-tool
> eth0: 10 Mbit, half duplex, no link
> eth1: 10 Mbit, half duplex, no link
>
> I can get correct status on fixed kernel.
>
> # mii-tool
> eth0: negotiated 100baseTx-FD, link okZZ
> eth1: negotiated 100baseTx-FD, link ok
>
There is a problem with this patch. I'm aware of this problem for
quite some time, but chose to keep the current code.
This IOCTL implementation has been here for many years in all
revisions of the driver, so I think we should keep it as is, because
some software could rely on it, and your change will break it.
And all new code should use ethtool anyway :).
--
Eugene
next prev parent reply other threads:[~2005-04-15 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 18:20 {PATCH] Fix IBM EMAC driver ioctl bug Geoff Levand
2005-04-15 4:01 ` Eugene Surovegin [this message]
2005-05-16 2:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050415040112.GB11362@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).