* {PATCH] Fix IBM EMAC driver ioctl bug
@ 2005-04-14 18:20 Geoff Levand
2005-04-15 4:01 ` Eugene Surovegin
2005-05-16 2:44 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Geoff Levand @ 2005-04-14 18:20 UTC (permalink / raw)
To: Matt Porter; +Cc: linux-kernel, linuxppc-embedded
Fix IBM EMAC driver ioctl bug.
I found IBM EMAC driver bug.
So mii-tool command print wrong status.
# mii-tool
eth0: 10 Mbit, half duplex, no link
eth1: 10 Mbit, half duplex, no link
I can get correct status on fixed kernel.
# mii-tool
eth0: negotiated 100baseTx-FD, link okZZ
eth1: negotiated 100baseTx-FD, link ok
Hiroaki Fuse
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> for CELF
---
Index: linux-2.6.11/drivers/net/ibm_emac/ibm_emac_core.c
===================================================================
--- linux-2.6.11.orig/drivers/net/ibm_emac/ibm_emac_core.c 2005-04-14 10:54:20.014023550 -0700
+++ linux-2.6.11/drivers/net/ibm_emac/ibm_emac_core.c 2005-04-14 10:55:24.723458722 -0700
@@ -1587,7 +1587,7 @@
static int emac_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
struct ocp_enet_private *fep = dev->priv;
- uint *data = (uint *) & rq->ifr_ifru;
+ uint16_t *data = (uint16_t *) & rq->ifr_ifru;
switch (cmd) {
case SIOCGMIIPHY:
-EOF
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: {PATCH] Fix IBM EMAC driver ioctl bug
2005-04-14 18:20 {PATCH] Fix IBM EMAC driver ioctl bug Geoff Levand
@ 2005-04-15 4:01 ` Eugene Surovegin
2005-05-16 2:44 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Eugene Surovegin @ 2005-04-15 4:01 UTC (permalink / raw)
To: Geoff Levand; +Cc: linux-kernel, linuxppc-embedded
On Thu, Apr 14, 2005 at 11:20:32AM -0700, Geoff Levand wrote:
> Fix IBM EMAC driver ioctl bug.
>
> I found IBM EMAC driver bug.
> So mii-tool command print wrong status.
>
> # mii-tool
> eth0: 10 Mbit, half duplex, no link
> eth1: 10 Mbit, half duplex, no link
>
> I can get correct status on fixed kernel.
>
> # mii-tool
> eth0: negotiated 100baseTx-FD, link okZZ
> eth1: negotiated 100baseTx-FD, link ok
>
There is a problem with this patch. I'm aware of this problem for
quite some time, but chose to keep the current code.
This IOCTL implementation has been here for many years in all
revisions of the driver, so I think we should keep it as is, because
some software could rely on it, and your change will break it.
And all new code should use ethtool anyway :).
--
Eugene
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: {PATCH] Fix IBM EMAC driver ioctl bug
2005-04-14 18:20 {PATCH] Fix IBM EMAC driver ioctl bug Geoff Levand
2005-04-15 4:01 ` Eugene Surovegin
@ 2005-05-16 2:44 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2005-05-16 2:44 UTC (permalink / raw)
To: Geoff Levand; +Cc: linux-kernel, linuxppc-embedded
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-16 3:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-14 18:20 {PATCH] Fix IBM EMAC driver ioctl bug Geoff Levand
2005-04-15 4:01 ` Eugene Surovegin
2005-05-16 2:44 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).