linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Surovegin <ebs@ebshome.net>
To: linuxppc-embedded@ozlabs.org
Subject: [RFC] [PATCH] ppc32: workaround for spurious IRQs on PQ2
Date: Tue, 26 Apr 2005 12:21:40 -0700	[thread overview]
Message-ID: <20050426192140.GB22714@gate.ebshome.net> (raw)

Hi!

There is a problem with big amount of spurious IRQs on 8248-based 
design I'm working on.

I observed this problem with 2.4.30 kernel, but it was reported to be
still present on 2.6 as well.

Traces show that spurious IRQ happens right after handle_IRQ_events() 
enables external interrupts and _before_ even calling real IRQ 
handler.

I fixed this problem by adding sync at the end of cpm2_mask_and_ack. 
Using out_XXX macros for accessing SIU register doesn't seem to help.
Dan thinks there are some pipeline-related issues here, although I 
failed to found any mentions of them in 8272 user manual.

Also, there is a possibility, that we need more explicit sync's in 
cpm2_pic code.

Signed-off-by: Eugene Surovegin <ebs@ebshome.net>

===== arch/ppc/syslib/cpm2_pic.c 1.11 vs edited =====
--- 1.11/arch/ppc/syslib/cpm2_pic.c	2005-03-31 02:59:05 -08:00
+++ edited/arch/ppc/syslib/cpm2_pic.c	2005-04-26 11:55:51 -07:00
@@ -90,6 +90,7 @@
 	ppc_cached_irq_mask[word] &= ~(1 << bit);
 	simr[word] = ppc_cached_irq_mask[word];
 	sipnr[word] = 1 << bit;
+	mb();
 }
 
 static void cpm2_end_irq(unsigned int irq_nr)

             reply	other threads:[~2005-04-26 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-26 19:21 Eugene Surovegin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-04-27  6:54 [RFC] [PATCH] ppc32: workaround for spurious IRQs on PQ2 Wrobel Heinz-r39252
2005-04-27  7:15 ` Eugene Surovegin
2005-04-27  7:39 ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050426192140.GB22714@gate.ebshome.net \
    --to=ebs@ebshome.net \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).