From: wrobell <wrobell@pld-linux.org>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] pmac: Improve sleep code of tumbler driver
Date: Wed, 4 May 2005 11:30:12 +0100 [thread overview]
Message-ID: <20050504103012.GA6851@borg> (raw)
In-Reply-To: <1113208474.8933.12.camel@gaston>
On Mon, Apr 11, 2005 at 06:34:34PM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2005-04-11 at 10:18 +0200, Colin Leroy wrote:
> > On Mon, 11 Apr 2005 12:00:54 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > This patch (applies on top of my previous one adding support for newer
> > > machines) improves the behaviour of the "tumbler/snapper" driver used
> > > on newer PowerMacs during sleep. It properly set the HW mutes to shut
> > > down amplifiers and does an analog shutdown of the codec. That might
> > > improve power consumption during sleep on a number of machines.
> >
> > I suppose it also fixes the occasionnal loud static noise that
> > sometimes at wakeup, for example on iBook G4s. Good :)
>
> I don't know, tell me. I didn't know about this problem.
Point 3 in
http://lists.debian.org/debian-powerpc/2004/11/msg00383.html
:-)
Anyway, now there is no distortion/noise at sleep/wakeup (linus git tree).
Thanks for your great work!
Regards,
wrobell <wrobell@pld-linux.org>
next prev parent reply other threads:[~2005-05-04 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-11 2:00 [PATCH] pmac: Improve sleep code of tumbler driver Benjamin Herrenschmidt
2005-04-11 8:18 ` Colin Leroy
2005-04-11 8:34 ` Benjamin Herrenschmidt
2005-04-11 8:45 ` Colin Leroy
2005-05-04 10:30 ` wrobell [this message]
2005-04-11 19:42 ` Vincent Lefevre
2005-04-11 22:49 ` Andreas Schwab
2005-04-11 13:56 ` Takashi Iwai
2005-04-17 9:18 ` Status report for 2.6.12-rc2 Wolfram Quester
2005-04-19 23:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050504103012.GA6851@borg \
--to=wrobell@pld-linux.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).