From: Eugene Surovegin <ebs@ebshome.net>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [RFC][PATCH 2.6.12-rc2] Updated platform additions for 82xx
Date: Fri, 6 May 2005 01:18:06 -0700 [thread overview]
Message-ID: <20050506081805.GA19401@gate.ebshome.net> (raw)
In-Reply-To: <427B22A0.8010704@ru.mvista.com>
On Fri, May 06, 2005 at 11:54:08AM +0400, Vitaly Bordug wrote:
[snip]
> +static struct cpm2_fec_platform_data mpc82xx_fcc1_pdata = {
> + .cp_page = CPM_CR_FCC1_PAGE,
> + .cp_block = CPM_CR_FCC1_SBLOCK,
> + .clk_trx = (PC_F1RXCLK | PC_F1TXCLK),
> + .clk_route = CMX1_CLK_ROUTE,
> + .clk_mask = CMX1_CLK_MASK,
> + .mdio = PC_MDIO,
> + .mdck = PC_MDCK,
> +
> + .device_flags = FSL_CPM2_FEC_BRD_HAS_PHY_INTR,
> + .phyid = 0,
> + .interruptPHY = SIU_INT_IRQ5,
> +};
Hmm, interruptPHY here still looks somewhat odd. Why not use the same
approach as for the rest of the fields - "default" if corresponding
define wasn't defined by the board port?
Not that I like this approach, IMHO there should be _NO_ defines at
all here and board setup code must fill them, but I guess it's OK
for now, mostly because there is no board specific files for 82xx
boards yet and this makes the patch quite small.
--
Eugene
next prev parent reply other threads:[~2005-05-06 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 7:54 [RFC][PATCH 2.6.12-rc2] Updated platform additions for 82xx Vitaly Bordug
2005-05-06 8:18 ` Eugene Surovegin [this message]
2005-05-06 9:09 ` Vitaly Bordug
2005-05-06 17:08 ` Eugene Surovegin
2005-05-06 17:23 ` Dan Malek
2005-05-06 17:32 ` Eugene Surovegin
2005-05-06 17:45 ` Dan Malek
2005-05-06 18:16 ` Eugene Surovegin
2005-05-06 18:43 ` Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506081805.GA19401@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).