From: Eugene Surovegin <ebs@ebshome.net>
To: Dan Malek <dan@embeddededge.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [RFC][PATCH 2.6.12-rc2] Updated platform additions for 82xx
Date: Fri, 6 May 2005 10:32:46 -0700 [thread overview]
Message-ID: <20050506173246.GD19401@gate.ebshome.net> (raw)
In-Reply-To: <7ad6626ea88c1e1ec98d310f4db438f7@embeddededge.com>
On Fri, May 06, 2005 at 01:23:21PM -0400, Dan Malek wrote:
>
> On May 6, 2005, at 1:08 PM, Eugene Surovegin wrote:
>
> >Yeah, it's better, I'm only wondering what if some board has separate
> >PHY interrupt lines for each FCC? Define name - "PHY_INTERRUPT" was
> >chosen quite badly IMHO :).
>
> One of my feature_calls is:
> embed_feature_call(CPM_FTR_FCC1, REQ_FTR_PHY_INT, &irq)
>
> and so on for every Ethernet port. This presents my current coding
> challenge, do I want this to be a varargs function or we just always
> have
> three parameters, where the last one is ignored if not necessary, a
> pointer for an out value, or a pointer to a data structure for more
> complex information. Right now I have it coded as always three
> parameters.
Yeah, I think 3 parameters approach is OK. IOCTL handlers are made
like this and so far they proved to be quite flexible.
--
Eugene
next prev parent reply other threads:[~2005-05-06 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 7:54 [RFC][PATCH 2.6.12-rc2] Updated platform additions for 82xx Vitaly Bordug
2005-05-06 8:18 ` Eugene Surovegin
2005-05-06 9:09 ` Vitaly Bordug
2005-05-06 17:08 ` Eugene Surovegin
2005-05-06 17:23 ` Dan Malek
2005-05-06 17:32 ` Eugene Surovegin [this message]
2005-05-06 17:45 ` Dan Malek
2005-05-06 18:16 ` Eugene Surovegin
2005-05-06 18:43 ` Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506173246.GD19401@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).