From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fed1rmmtao06.cox.net (fed1rmmtao06.cox.net [68.230.241.33]) by ozlabs.org (Postfix) with ESMTP id 623D7679EB for ; Tue, 10 May 2005 23:28:23 +1000 (EST) Date: Tue, 10 May 2005 06:27:44 -0700 From: Matt Porter To: Dan Malek Message-ID: <20050510062744.A21835@cox.net> References: <427F4D3F.1010802@intracom.gr> <20050509133808.A16776@cox.net> <4280985D.80108@intracom.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: ; from dan@embeddededge.com on Tue, May 10, 2005 at 08:13:48AM -0400 Cc: Tom Rini , linuxppc-embedded Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 10, 2005 at 08:13:48AM -0400, Dan Malek wrote: > > On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote: > > > This patch replace iopa use with virt_to_phys. > > Not gonna work ..... > > When you map uncached on 8xx you get a new vmalloc() > space. The virt_to_xxx macros don't work on those addresses. > You need to use the dma_consistent() function, stash the > real physical address it returns and then use it where > appropriate. That and the use of virt_to_* and friends is deprecated by the DMA API. You'll never get that upstream even if it were a case where it did work. That's a good thing to know for anybody doing other drivers... -Matt