From: Colin Leroy <colin@colino.net>
To: "Nghiem, Tien" <TNghiem@oerlikon.ca>
Cc: linuxppc-dev@ozlabs.org, "Garcia Jérémie" <GARCIAJ@3il.fr>
Subject: Re: eth0: PHY id 0x00221619 is not supported! HELP
Date: Fri, 13 May 2005 21:30:49 +0200 [thread overview]
Message-ID: <20050513213049.222963d3@jack.colino.net> (raw)
In-Reply-To: <CCD52035B75A5D4E8A481EFB132C42EA28E5CF@mail.oerlikon.ca>
On 13 May 2005 at 14h05, Nghiem, Tien wrote:
Hi,
> rc = reset_one_mii_phy(phy, mii_id);
> //if (rc)
> // return -ENODEV;
Why disabling such guards?
> //for (i=0; (def = mii_phy_table[i]) != NULL; i++)
> // if ((id & def->phy_id_mask) == def->phy_id)
> // break;
Just an idea, I guess it'd be far more clean to add the phy id to
mii_phy_table[] (and, optionally, send the patch so you won't have to
do it everytime).
You're just asking for breakage there.
--
Colin
next prev parent reply other threads:[~2005-05-13 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 18:25 eth0: PHY id 0x00221619 is not supported! HELP Nghiem, Tien
2005-05-13 19:30 ` Colin Leroy [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-13 20:36 Nghiem, Tien
2005-05-13 15:15 Garcia Jérémie
2005-05-13 15:39 ` Clemens Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050513213049.222963d3@jack.colino.net \
--to=colin@colino.net \
--cc=GARCIAJ@3il.fr \
--cc=TNghiem@oerlikon.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox