LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Zeffertt <ajz@cambridgebroadband.com>
To: linuxppc-embedded@ozlabs.org
Subject: set_multicast_list() commented out in fcc_enet.c
Date: Tue, 31 May 2005 10:23:23 +0100	[thread overview]
Message-ID: <20050531102323.0fbc2b5e.ajz@cambridgebroadband.com> (raw)

Hi all,

I've noticed that in arch/ppc/8260_io/fcc_enet.c at the very top of the
function set_multicast_list() there is a return statement - effectively
commenting out the rest of the code.  There is no comment saying why it
is there.

An effect of this is that you cannot put the device in promiscuous mode,
which is required when adding it to a bridge.

Please can anyone say why this "return;" is there?

Thanks,

Alex

PS I'm using denx's linuxppc_devel tagged 2005-03-06, which is based
on linux-2.4.25.

             reply	other threads:[~2005-05-31  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31  9:23 Alex Zeffertt [this message]
2005-05-31  9:38 ` set_multicast_list() commented out in fcc_enet.c Benjamin Dapon-Pigatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050531102323.0fbc2b5e.ajz@cambridgebroadband.com \
    --to=ajz@cambridgebroadband.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox