From: Stephen Hemminger <shemminger@osdl.org>
To: Andy Fleming <afleming@freescale.com>
Cc: Netdev <netdev@oss.sgi.com>,
Embedded PPC Linux list <linuxppc-embedded@ozlabs.org>
Subject: Re: RFC: PHY Abstraction Layer II
Date: Wed, 1 Jun 2005 14:41:23 -0700 [thread overview]
Message-ID: <20050601144123.2bc11c06@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <92F1428A-0B26-428B-8C06-35C7E5B9EEE3@freescale.com>
On Wed, 1 Jun 2005 15:45:26 -0500
Andy Fleming <afleming@freescale.com> wrote:
>
> On May 31, 2005, at 12:59, Stephen Hemminger wrote:
>
> > Here are some patches:
> > * allow phy's to be modules
> > * use driver owner for ref count
> > * make local functions static where ever possible
>
> I agree with all these.
>
> > * get rid of bus read may sleep implication in comment.
> > since you are holding phy spin lock it better not!!
>
On a different note, I am not sure that using sysfs/kobject bus object
is the right thing for this object. Isn't the phy instance really just
an kobject whose parent is the network device? I can't see a 1 to N
relationship between phy bus and phy objects existing.
The main use I can see for being a driver object is to catch suspend/resume,
and wouldn't you want that to be tied to the network device.
next prev parent reply other threads:[~2005-06-01 21:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 1:47 RFC: PHY Abstraction Layer II Andy Fleming
2005-03-09 2:14 ` Benjamin Herrenschmidt
2005-03-09 3:42 ` David S. Miller
2005-03-09 3:50 ` Benjamin Herrenschmidt
2005-03-09 17:24 ` Andy Fleming
2005-03-10 23:01 ` James Chapman
2005-03-10 23:06 ` Benjamin Herrenschmidt
2005-03-10 23:27 ` Jeff Garzik
2005-03-10 23:27 ` Benjamin Herrenschmidt
2005-03-15 0:41 ` Andy Fleming
2005-03-15 19:18 ` James Chapman
2005-03-18 23:14 ` Andy Fleming
2005-03-24 21:48 ` Andy Fleming
2005-03-25 22:56 ` Andy Fleming
2005-03-28 23:45 ` Kumar Gala
2005-03-29 4:11 ` Problem when accessing variables Hiep Tran
[not found] ` <42625DDB.4090600@katalix.com>
2005-05-10 17:04 ` RFC: PHY Abstraction Layer II Andy Fleming
2005-05-12 6:08 ` Pantelis Antoniou
2005-05-25 23:00 ` Kumar Gala
2005-03-09 17:17 ` Andy Fleming
2005-05-26 18:32 ` Stephen Hemminger
2005-05-26 18:45 ` Andy Fleming
2005-05-31 17:59 ` Stephen Hemminger
2005-06-01 20:45 ` Andy Fleming
2005-06-01 21:19 ` Stephen Hemminger
2005-06-01 22:42 ` Andy Fleming
2005-06-01 21:41 ` Stephen Hemminger [this message]
2005-06-01 22:36 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601144123.2bc11c06@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=afleming@freescale.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).