From: Greg KH <greg@kroah.com>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][1/3] RapidIO support: core
Date: Wed, 1 Jun 2005 17:02:28 -0700 [thread overview]
Message-ID: <20050602000228.GB5678@kroah.com> (raw)
In-Reply-To: <20050601110836.A16559@cox.net>
On Wed, Jun 01, 2005 at 11:08:36AM -0700, Matt Porter wrote:
> Patch is 108KB and can be found here:
> ftp://source.mvista.com/pub/rio/l26_rio_core.patch
register_driver() does not return the number of devices bound to the
driver. So your comment in rio_register_driver() is incorrect. Just
return count.
Hm, if the patch was inline it would be easier to comment on stuff like
this, I'll wait till then for the rest :)
thanks,
greg k-h
prev parent reply other threads:[~2005-06-01 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 18:08 [PATCH][1/3] RapidIO support: core Matt Porter
2005-06-01 18:15 ` [PATCH][2/3] RapidIO support: ppc32 Matt Porter
2005-06-01 18:25 ` [PATCH][3/3] RapidIO support: net driver over messaging Matt Porter
2005-06-01 22:58 ` [PATCH][1/3] RapidIO support: core Matt Porter
2005-06-02 0:00 ` Greg KH
2005-06-02 0:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050602000228.GB5678@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).