From: Eugene Surovegin <ebs@ebshome.net>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] [1/2] PM support for Ebony
Date: Mon, 6 Jun 2005 11:25:01 -0700 [thread overview]
Message-ID: <20050606182501.GA10988@gate.ebshome.net> (raw)
In-Reply-To: <42A49084.3070002@am.sony.com>
On Mon, Jun 06, 2005 at 11:05:56AM -0700, Geoff Levand wrote:
> I was thinking to add a static variable in ppc4xx_pic.c to hold the
> state, that way the arch pm code doesn't need to take care of it,
> which will make suspend to disk easier since the value will be
> saved in the system image. I'm not sure which way to go. Any
> comments?
I don't have a problem with having static variables for PM in
ppc4xx_pic.c. However, why only one for UIC0? What about UIC1? What
about UIC2 (for 440GX) ?
Also, function, you just added, uses resume_bits are for UIC0, it's
not clear from the function prototype why just UIC0. Shouldn't it be
more generic?
Another note, code in ebony_pm_enter doesn't look very Ebony specific,
maybe it's would be a good idea to move most of it into ibm440gp_sleep.
--
Eugene
next prev parent reply other threads:[~2005-06-06 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 23:22 [PATCH] [1/2] PM support for Ebony Geoff Levand
2005-06-03 23:23 ` Benjamin Herrenschmidt
2005-06-04 0:51 ` Eugene Surovegin
2005-06-06 13:50 ` Geoff Levand
2005-06-06 18:05 ` Geoff Levand
2005-06-06 18:25 ` Eugene Surovegin [this message]
2005-06-06 18:59 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606182501.GA10988@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).