From: Eugene Surovegin <ebs@ebshome.net>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: akpm@osdl.org, trini@kernel.crashing.org,
linux-kernel@vger.kernel.org, linuxppc-embedded@ozlabs.org,
Andrei Konovalov <akonovalov@ru.mvista.com>,
yshpilevsky@ru.mvista.com
Subject: Re: [PATCH] ppc32: add Freescale MPC885ADS board support
Date: Thu, 23 Jun 2005 12:48:56 -0700 [thread overview]
Message-ID: <20050623194856.GA4588@gate.ebshome.net> (raw)
In-Reply-To: <20050623140522.GA25724@logos.cnet>
On Thu, Jun 23, 2005 at 11:05:22AM -0300, Marcelo Tosatti wrote:
>
> Hi Andrei,
>
> On Thu, Jun 23, 2005 at 07:38:54PM +0400, Andrei Konovalov wrote:
> <snip>
>
> > diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c
> > --- a/arch/ppc/syslib/m8xx_setup.c
> > +++ b/arch/ppc/syslib/m8xx_setup.c
> > @@ -369,7 +369,7 @@ m8xx_map_io(void)
> > #if defined(CONFIG_HTDMSOUND) || defined(CONFIG_RPXTOUCH) || defined(CONFIG_FB_RPX)
> > io_block_mapping(HIOX_CSR_ADDR, HIOX_CSR_ADDR, HIOX_CSR_SIZE, _PAGE_IO);
> > #endif
> > -#ifdef CONFIG_FADS
> > +#if defined(CONFIG_FADS) || defined(CONFIG_MPC885ADS)
> > io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO);
> > #endif
> > #ifdef CONFIG_PCI
>
> I suppose you also want to include CONFIG_MPC885ADS in the io_block_mapping(IO_BASE)
> here?
I think it'd be great if we _stop_ adding new io_block_mapping users,
there is ioremap() for stuff like this, let's use it instead.
--
Eugene
next prev parent reply other threads:[~2005-06-23 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 15:38 [PATCH] ppc32: add Freescale MPC885ADS board support Andrei Konovalov
2005-06-23 14:05 ` Marcelo Tosatti
2005-06-23 19:48 ` Eugene Surovegin [this message]
2005-06-23 20:03 ` Marcelo Tosatti
2005-06-24 2:11 ` Eugene Surovegin
2005-06-24 15:21 ` Andrei Konovalov
2005-06-24 15:43 ` Tom Rini
2005-06-24 16:29 ` Andrei Konovalov
2005-06-24 16:58 ` Tom Rini
2005-06-29 10:03 ` [PATCH] ppc32: add Freescale MPC885ADS board support - new MPC885ADS patch plus updated MPC86xADS Andrei Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050623194856.GA4588@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=akonovalov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=trini@kernel.crashing.org \
--cc=yshpilevsky@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).