From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <trini@kernel.crashing.org>
Received: from fed1rmmtao11.cox.net (fed1rmmtao11.cox.net [68.230.241.28])
	by ozlabs.org (Postfix) with ESMTP id 82D7B67A6D
	for <linuxppc-embedded@ozlabs.org>;
	Sat, 25 Jun 2005 01:43:14 +1000 (EST)
Date: Fri, 24 Jun 2005 08:43:12 -0700
From: Tom Rini <trini@kernel.crashing.org>
To: Andrei Konovalov <akonovalov@ru.mvista.com>
Message-ID: <20050624154311.GB3628@smtp.west.cox.net>
References: <42BAD78E.1020801@ru.mvista.com>
	<20050623140522.GA25724@logos.cnet>
	<42BC2501.5090101@ru.mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <42BC2501.5090101@ru.mvista.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, yshpilevsky@ru.mvista.com,
	linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] ppc32: add Freescale MPC885ADS board support
List-Id: Linux on Embedded PowerPC Developers Mail List
	<linuxppc-embedded.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-embedded>,
	<mailto:linuxppc-embedded-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-embedded>
List-Post: <mailto:linuxppc-embedded@ozlabs.org>
List-Help: <mailto:linuxppc-embedded-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-embedded>,
	<mailto:linuxppc-embedded-request@ozlabs.org?subject=subscribe>

On Fri, Jun 24, 2005 at 07:21:37PM +0400, Andrei Konovalov wrote:
> Hi Marcelo,
> 
> Marcelo Tosatti wrote:
> >Hi Andrei,
> >
> >On Thu, Jun 23, 2005 at 07:38:54PM +0400, Andrei Konovalov wrote:
> ><snip>
> >
> >>diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c
> >>--- a/arch/ppc/syslib/m8xx_setup.c
> >>+++ b/arch/ppc/syslib/m8xx_setup.c
> >>@@ -369,7 +369,7 @@ m8xx_map_io(void)
> >>#if defined(CONFIG_HTDMSOUND) || defined(CONFIG_RPXTOUCH) || 
> >>defined(CONFIG_FB_RPX)
> >>	io_block_mapping(HIOX_CSR_ADDR, HIOX_CSR_ADDR, HIOX_CSR_SIZE, 
> >>	_PAGE_IO);
> >>#endif
> >>-#ifdef CONFIG_FADS
> >>+#if defined(CONFIG_FADS) || defined(CONFIG_MPC885ADS)
> >>	io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO);
> >>#endif
> >>#ifdef CONFIG_PCI
> >
> >
> >I suppose you also want to include CONFIG_MPC885ADS in the 
> >io_block_mapping(IO_BASE) here?
> 
> No, not at the moment at least.
> Actually, the patch doesn't even #define IO_BASE.
> In 2.4 that io_block_mapping(IO_BASE) was needed for PCMCIA / CF cards to 
> work.
> We haven't got to PCMCIA support in 2.6 yet, and PCMCIA is unlikely to work
> as is in case of MPC885ADS, as drivers/pcmcia/m8xx_pcmcia.c is just missing.
> We plan to address PCMCIA later.

Lets just drop that hunk then..

-- 
Tom Rini
http://gate.crashing.org/~trini/