From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Loeliger <jdl@freescale.com>
Cc: linuxppc64-dev@ozlabs.org,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: PATCH: Add memreserve to DTC
Date: Fri, 15 Jul 2005 17:19:24 +1000 [thread overview]
Message-ID: <20050715071924.GA16797@localhost.localdomain> (raw)
In-Reply-To: <1121371427.24467.34.camel@cashmere.sps.mot.com>
On Thu, Jul 14, 2005 at 03:03:47PM -0500, Jon Loeliger wrote:
> On Mon, 2005-07-11 at 23:06, David Gibson wrote:
> > On Mon, Jul 11, 2005 at 04:22:30PM -0500, Jon Loeliger wrote:
> > > On Sun, 2005-07-10 at 23:55, David Gibson wrote:
> > > > On Fri, Jul 08, 2005 at 04:44:58PM -0500, Jon Loeliger wrote:
> > [snip]
> > > > Biggest thing is that rather than passing the tree itself and the
> > > > memreserve info about as two parameters all over the place, I'd rather
> > > > create a new structure which has both (and later can have anything
> > > > else that might be needed).
> > >
> > > If you'd like, I'll do this work.
> >
> > That would be helpful. You'll need to rediff, though, I merged a
> > couple of bugfixes from your patch that weren't directly related to
> > the memreserve stuff.
>
> David,
>
> Here is an updated version of the patch that obsoletes
> the previous one I submitted. I have incorporated all
> of your syntactic suggestions except not using the
> split-64 values (ie, this still uses 'struct data').
> It primarily merges in the changes that you adopted
> from earlier and implements a new structure at the
> base of the parse tree to hold both the device tree
> and the header information. I called that new stucuture
> 'struct header_tree'. Feel free to dream up something
> better. :-)
Ok, I've merged this, although I've tweaked things substantially in
the process. I did rename "header_tree" to "boot_info", moved some
things around, and changed the syntax. Reserve ranges can now be
specified either as an address and length:
/memreserve/ 10000000 00002000;
or as an (inclusive) address range:
/memreserve/ 10000000-10001fff;
I am a bit worried that those two forms may be hard to distinguish at
a glance. Any sugggestions for changes to the syntax soon please, I'd
really like to keep the source syntax as stable as possible.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2005-07-15 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 21:44 PATCH: Add memreserve to DTC Jon Loeliger
2005-07-11 4:55 ` David Gibson
2005-07-11 21:22 ` Jon Loeliger
2005-07-12 2:01 ` David Gibson
2005-07-12 8:02 ` Segher Boessenkool
2005-07-14 1:02 ` David Gibson
2005-07-14 13:29 ` Segher Boessenkool
2005-07-12 4:06 ` David Gibson
2005-07-14 20:03 ` Jon Loeliger
2005-07-15 7:19 ` David Gibson [this message]
2005-07-15 14:30 ` Jon Loeliger
2005-07-19 1:17 ` David Gibson
2005-07-11 6:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050715071924.GA16797@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).