From: Stefan Roese <sr@denx.de>
To: linuxppc-embedded@ozlabs.org
Cc: John Otken <jotken@softadvances.com>
Subject: Re: [PATCH] Support for AMCC Yosemite 440EP Eval Board
Date: Wed, 27 Jul 2005 15:47:30 +0200 [thread overview]
Message-ID: <200507271547.30827.sr@denx.de> (raw)
In-Reply-To: <42E776DD.9080307@softadvances.com>
Hi John,
On Wednesday 27 July 2005 13:58, John Otken wrote:
> This patch adds support for the new AMCC Yosemite 440EP Eval
> Board. I tested it on the both Bamboo and Yosemite boards
> using the 2.6.12 kernel.
How about a patch against a more recent kernel?
> This patch has three dependencies:
> 2005-04-07 Wade Farnsworth's PPC440EP SoC and Bamboo board support
Please use the patches Wade sent yesterday to this list.
> 2005-07-20 My fix invalid function name usb_hcd_put in ohci-ppc-soc.c
> 2005-07-27 My Support 440EP On-Chip OHCI USB Host Controller
>
> http://patchwork.ozlabs.org/linuxppc/patch?id=1311
> http://patchwork.ozlabs.org/linuxppc/patch?id=1803
> http://patchwork.ozlabs.org/linuxppc/patch?id=1855
>
> Comments are welcome.
OK, here we go...
<snip>
> diff -uprN c/arch/ppc/platforms/4xx/bamboo.c
> d/arch/ppc/platforms/4xx/bamboo.c ---
> c/arch/ppc/platforms/4xx/bamboo.c 2005-07-25 06:34:52.000000000 -0500 +++
> d/arch/ppc/platforms/4xx/bamboo.c 2005-07-26 10:31:37.000000000 -0500 @@
> -59,6 +59,20 @@
> */
> #include "../../../../drivers/net/ibm_emac/ibm_emac_phy.h"
>
> +#if defined(CONFIG_BAMBOO)
> +static const int bamboo = 1;
> +static const char cpu_name[] = {"440EP"};
> +static const char brd_name[] = {"Bamboo"};
> +#elif defined(CONFIG_YELLOWSTONE)
> +static const int bamboo = 0;
> +static const char cpu_name[] = {"440GR"};
> +static const char brd_name[] = {"Yellowstone"};
> +#else
> +static const int bamboo = 0;
> +static const char cpu_name[] = {"440EP"};
> +static const char brd_name[] = {"Yosemite"};
> +#endif
> +
Hmmm. You seem to include not only the Yosemite but also the Yellowstone with
a different processor type (440GR) into the bamboo platform file. I would
prefer seperate platform files for the different boards, especially since the
differences are not marginal.
<snip>
> diff -uprN c/arch/ppc/platforms/4xx/Makefile
> d/arch/ppc/platforms/4xx/Makefile ---
> c/arch/ppc/platforms/4xx/Makefile 2005-07-24 16:14:36.000000000 -0500 +++
> d/arch/ppc/platforms/4xx/Makefile 2005-07-26 10:51:35.000000000 -0500 @@
> -15,6 +15,7 @@ obj-$(CONFIG_REDWOOD_6) += redwood6.o
> obj-$(CONFIG_SYCAMORE) += sycamore.o
> obj-$(CONFIG_WALNUT) += walnut.o
> obj-$(CONFIG_XILINX_ML300) += xilinx_ml300.o
> +obj-$(CONFIG_YOSEMITE) += bamboo.o
Please see above.
Best regards,
Stefan
next prev parent reply other threads:[~2005-07-27 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 11:58 [PATCH] Support for AMCC Yosemite 440EP Eval Board John Otken
2005-07-27 13:47 ` Stefan Roese [this message]
2005-07-27 15:59 ` Eugene Surovegin
2005-07-27 16:29 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507271547.30827.sr@denx.de \
--to=sr@denx.de \
--cc=jotken@softadvances.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).