From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.203]) by ozlabs.org (Postfix) with ESMTP id 28F1367D77 for ; Wed, 3 Aug 2005 05:08:10 +1000 (EST) Received: by wproxy.gmail.com with SMTP id i16so1216244wra for ; Tue, 02 Aug 2005 12:08:09 -0700 (PDT) From: Pantelis Antoniou To: Vitaly Bordug Date: Wed, 3 Aug 2005 00:26:30 +0300 References: <42EF9022.5050707@ru.mvista.com> In-Reply-To: <42EF9022.5050707@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200508030026.31224.pantelis.antoniou@gmail.com> Cc: Kumar Gala , linuxppc-embedded list Subject: Re: [PATCH] cpm_uart: Made non-console uart work Reply-To: pantelis.antoniou@gmail.com List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 02 August 2005 18:24, Vitaly Bordug wrote: > Kumar, Pantelis, > > This patch makes non-console UART work on both 8xx and 82xx. Various > issues are resolved: > - removed unnecessary STOP_TX commands in shutdown - no need to > completely stop CPM TX and reinit BDs each time the port is closing; > - when mem_addr has been allocated via dma_coherent_alloc, virt_to_bus > on it will not tell the truth in most cases > - SCC UART needs to wait several character times even after all the BDs > have READY bit cleared > - adds needed board-specific bits for 86xADS > > Tested on 8272ADS, 885ADS and 866ADS development boards. > --------------------------------- > Signed-off-by: Vitaly Bordug Vitaly, this patch is clearly in conflict with mine. Mind taking a look at my patch and include the changes I've made? You'll only have to change the cpm2cpu & cpu2cpm functions... I would also argue that the STOP_TX command is needed at shutdown, since this is the canonical way serial ports operate in linux. Also you might want to change the protocol running on an SCC port after shutdown. The rest are fine... Regards Pantelis