From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] 8xx: add cpm_get_cpmp()
Date: Sat, 6 Aug 2005 21:33:24 -0300 [thread overview]
Message-ID: <20050807003323.GB4828@dmt.cnet> (raw)
In-Reply-To: <20050806234244.GB5210@cathedrallabs.org>
On Sat, Aug 06, 2005 at 08:42:44PM -0300, Aristeu Sergio Rozanski Filho wrote:
> > It already is exported, declared as
> >
> > commproc.h:extern cpm8xx_t *cpmp; /* Pointer to comm processor */
> >
> >
> > and many drivers use the pointer directly.
> >
> > arch/ppc/8260_io/ drivers also use the same convention.
> >
> > Not sure I see much advantage in changing it?
> but not with EXPORT_SYMBOL(). I noticed this while compiling i2c stuff
> as module.
Then other modules suffer from the same problem - what if you EXPORT_SYMBOL(cpmp)?
> also, I think it's better add a function to do this instead
> doing EXPORT_SYMBOL() in a variable.
> what you think?
Well it is better in theory because it hides details, but in practice
I'm not sure its worth it - the CPM pointer (along with the whole immap)
never changes during runtime.
next prev parent reply other threads:[~2005-08-07 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-06 18:03 [PATCH] 8xx: add cpm_get_cpmp() Aristeu Sergio Rozanski Filho
2005-08-06 23:27 ` Marcelo Tosatti
2005-08-06 23:42 ` Aristeu Sergio Rozanski Filho
2005-08-07 0:33 ` Marcelo Tosatti [this message]
2005-08-07 3:36 ` Dan Malek
2005-08-07 2:40 ` Dan Malek
2005-08-07 4:31 ` Marcelo Tosatti
2005-08-07 15:39 ` Dan Malek
2005-08-07 15:44 ` Aristeu Sergio Rozanski Filho
2005-08-07 15:57 ` Marcelo Tosatti
2005-08-07 19:18 ` Eugene Surovegin
2005-08-07 17:25 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050807003323.GB4828@dmt.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=aris@cathedrallabs.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).