Re: [PATCH] 8xx: add cpm_get_cpmp()

[Marcelo Tosatti <marcelo.tosatti@cyclades.com>]

On Sat, Aug 06, 2005 at 10:40:37PM -0400, Dan Malek wrote:
> 
> On Aug 6, 2005, at 7:27 PM, Marcelo Tosatti wrote:
> 
> >It already is exported, declared as
> >
> >commproc.h:extern       cpm8xx_t        *cpmp;          /* Pointer to 
> >comm processor */
> >
> >
> >and many drivers use the pointer directly.
> 
> We shouldn't be doing this.  All drivers should ioremap() any
> peripheral spaces they use and not make any assumptions
> someone else has done that already.  We've been making
> such changes in the 82xx/83xx/85xx CPM2 drivers.  If it
> isn't convenient to find the #defines for the ioremap(), we
> should change that.  When I originally wrote all of this
> code, it was long ago when we didn't have some of the
> abstractions and it seemed any shortcuts for performance
> were desired :-)

OK makes sense (yep it was even discussed already).

Aris, sounds like you should proceed with cpm_get_cpmp() and change all
other drivers using it also.

> 
> 
> >arch/ppc/8260_io/ drivers also use the same convention.
> 
> If there are any drivers in here, they either aren't used or
> on their way out.  The only things that should remain are
> common support functions.

OK!