linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matt Porter <mporter@kernel.crashing.org>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] add field to struct ocp_func_emac_data for platform-specific unsupported PHY features
Date: Mon, 8 Aug 2005 16:44:57 -0700	[thread overview]
Message-ID: <20050808164457.C9951@cox.net> (raw)
In-Reply-To: <1123284390.27734.19.camel@rhino.az.mvista.com>; from wfarnsworth@mvista.com on Fri, Aug 05, 2005 at 04:26:30PM -0700

On Fri, Aug 05, 2005 at 04:26:30PM -0700, Wade Farnsworth wrote:
>  static int
> --- linux-2.6/include/asm-ppc/ibm_ocp.h	2005-08-03 13:34:08.000000000 -0700
> +++ linux-2.6-dev/include/asm-ppc/ibm_ocp.h	2005-08-02 10:49:42.000000000 -0700
> @@ -67,6 +67,7 @@ struct ocp_func_emac_data {
>  	int	phy_mode;	/* PHY type or configurable mode */
>  	u8	mac_addr[6];	/* EMAC mac address */
>  	u32	phy_map;	/* EMAC phy map */
> +	u32	feat_unsupp;	/* Unsupported phy features */

Could you update this field (and related usages) to be "phy_ftr_exc"?
For "Excluded phy features".  Eugene and I discussed this on IRC and
think it's a better name...for one it starts with the phy_ prefix like
other related phy data. Except for that, it's ready for upstream.

Thanks,
Matt

  reply	other threads:[~2005-08-08 23:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-05 23:26 [PATCH] add field to struct ocp_func_emac_data for platform-specific unsupported PHY features Wade Farnsworth
2005-08-08 23:44 ` Matt Porter [this message]
2005-08-11 20:42   ` Wade Farnsworth
2005-08-13 19:32     ` Eugene Surovegin
2005-08-13 19:35       ` Eugene Surovegin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050808164457.C9951@cox.net \
    --to=mporter@kernel.crashing.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=wfarnsworth@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).