linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: Joakim Tjernlund <joakim.tjernlund@lumentis.se>,
	linuxppc-embedded@ozlabs.org
Subject: Re: Volunteers to test i2c-algo-8xx on v2.6?
Date: Tue, 9 Aug 2005 09:18:01 -0700	[thread overview]
Message-ID: <20050809161801.GK3187@smtp.west.cox.net> (raw)
In-Reply-To: <20050808130523.GF5210@cathedrallabs.org>

On Mon, Aug 08, 2005 at 10:05:23AM -0300, Aristeu Sergio Rozanski Filho wrote:
> Hi,
> > I have done this for cpm_iic_read, cpm_iic_write and cpm_iic_try_address.
> > Also note the the addition of "| 0x01" to i2c->i2c_i2com.
> the updated patch is attached, thanks Joakim.
> seems Debora need this too for 2.4 version. Debora, could you please
> generate a diff against latest Wolfgang's development tree and submit to
> him?

I've tested this version with my cheesy sttm reader on an rpxlite, and
with the following, things work:

Signed-off-by: Tom Rini <trini@kernel.crashing.org>

diff --git a/drivers/i2c/busses/i2c-rpx.c b/drivers/i2c/busses/i2c-rpx.c
--- a/drivers/i2c/busses/i2c-rpx.c
+++ b/drivers/i2c/busses/i2c-rpx.c
@@ -55,17 +55,7 @@ rpx_iic_init(struct i2c_algo_8xx_data *d
 	data->i2c = (i2c8xx_t *)&(((immap_t *)IMAP_ADDR)->im_i2c);
 }
 
-static int rpx_install_isr(int irq, void (*func)(void *, void *), void *data)
-{
-	/* install interrupt handler */
-	cpm_install_handler(irq, (void (*)(void *, struct pt_regs *)) func, data);
-
-	return 0;
-}
-
-static struct i2c_algo_8xx_data rpx_data = {
-	.setisr = rpx_install_isr
-};
+static struct i2c_algo_8xx_data rpx_data;
 
 static struct i2c_adapter rpx_ops = {
 	.owner		= THIS_MODULE,

-- 
Tom Rini
http://gate.crashing.org/~trini/

  reply	other threads:[~2005-08-09 16:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08  8:08 Volunteers to test i2c-algo-8xx on v2.6? Joakim Tjernlund
2005-08-08 13:05 ` Aristeu Sergio Rozanski Filho
2005-08-09 16:18   ` Tom Rini [this message]
2005-08-09 16:28     ` aris
2005-08-09 16:29     ` aris
2005-08-09 16:45       ` Tom Rini
     [not found] <20050809052142.2C53242C5E@denx.de>
2005-08-09 21:18 ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2005-08-08  1:53 Debora Liu
2005-08-06 18:01 [PATCH] 8xx: port i2c-algo-8xx to 2.6 Aristeu Sergio Rozanski Filho
2005-08-06 23:20 ` Marcelo Tosatti
2005-08-07  0:08   ` Aristeu Sergio Rozanski Filho
2005-08-07  0:34     ` Volunteers to test i2c-algo-8xx on v2.6? Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050809161801.GK3187@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=aris@cathedrallabs.org \
    --cc=joakim.tjernlund@lumentis.se \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).