linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: "Debora Liu" <deboralh@fel.com.cn>
Cc: Linuxppc-embedded <Linuxppc-embedded@ozlabs.org>
Subject: Re: Volunteers to test i2c-algo-8xx on v2.6?
Date: Tue, 09 Aug 2005 23:18:30 +0200	[thread overview]
Message-ID: <20050809211830.F214D352BD9@atlas.denx.de> (raw)
In-Reply-To: Your message of "Tue, 09 Aug 2005 13:25:42 +0800." <20050809052142.2C53242C5E@denx.de>

In message <20050809052142.2C53242C5E@denx.de> you wrote:
> 
> I'm working with Wolfgang's ELDK-3.1.1,
> diff against Wolfgang's ELDK-3.1.1 patch is attached.

Ummm... A quick scan showed only reformatting and  style  changes.  I
think  someone who really understands the controller should perform a
review of the code. There are most likely problems hidden - like  the
timeout  of  1  second  which is much too short; we measured nearly 4
seconds (under heavy load) between starting a  transfer  and  getting
the interrupt.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Work 8 hours, sleep 8 hours; but not the same 8 hours.

       reply	other threads:[~2005-08-09 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050809052142.2C53242C5E@denx.de>
2005-08-09 21:18 ` Wolfgang Denk [this message]
2005-08-08  8:08 Volunteers to test i2c-algo-8xx on v2.6? Joakim Tjernlund
2005-08-08 13:05 ` Aristeu Sergio Rozanski Filho
2005-08-09 16:18   ` Tom Rini
2005-08-09 16:28     ` aris
2005-08-09 16:29     ` aris
2005-08-09 16:45       ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2005-08-08  1:53 Debora Liu
2005-08-06 18:01 [PATCH] 8xx: port i2c-algo-8xx to 2.6 Aristeu Sergio Rozanski Filho
2005-08-06 23:20 ` Marcelo Tosatti
2005-08-07  0:08   ` Aristeu Sergio Rozanski Filho
2005-08-07  0:34     ` Volunteers to test i2c-algo-8xx on v2.6? Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050809211830.F214D352BD9@atlas.denx.de \
    --to=wd@denx.de \
    --cc=Linuxppc-embedded@ozlabs.org \
    --cc=deboralh@fel.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).