From: Tom Rini <trini@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] Use platform device for 8250 registration
Date: Wed, 17 Aug 2005 08:05:36 -0700 [thread overview]
Message-ID: <20050817150536.GN8214@smtp.west.cox.net> (raw)
In-Reply-To: <1124263872.3869.48.camel@localhost.localdomain>
On Wed, Aug 17, 2005 at 08:31:11AM +0100, David Woodhouse wrote:
> On Wed, 2005-08-17 at 01:30 -0500, Kumar Gala wrote:
> > > We could probably remove all the rest of the crap from asm/serial.h and
> > > let platforms register their own serial8250 platform devices...
>
> > Hmm, I wondering if we can provide some standard way of handling this
> > for the embedded platforms as well. It would be nice to drop the old
> > style of initialization completely and move to using a platform
> > device always.
>
> Yes, that's precisely what I meant. Just remove it from the list in
> serial.h and as Ben says, instantiating a platform device is easy.
>
> static struct plat_serial8250_port my_serial_ports[] = {
> {
> .uartclk = 115200*16,
> .iobase = 0x2f8,
> .irq = 3,
> .flags = ASYNC_BOOT_AUTOCONF;
> },
> };
So long as you convert arch/ppc/boot/ to this as well, why not (or at
least being able to grab the infos from these structs somehow).
Once everyone is on a flat tree, I don't object to killing all of the
old-style uart definitions steaming out of <asm-ppc/serial.h>.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-08-17 15:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-16 16:21 [PATCH] Use platform device for 8250 registration David Woodhouse
2005-08-17 6:30 ` Kumar Gala
2005-08-17 6:34 ` Benjamin Herrenschmidt
2005-08-17 7:31 ` David Woodhouse
2005-08-17 13:54 ` Kumar Gala
2005-08-17 15:05 ` Tom Rini [this message]
2005-08-17 15:22 ` Kumar Gala
2005-08-17 15:30 ` Tom Rini
2005-08-17 16:16 ` Kumar Gala
2005-08-17 16:27 ` Matt Porter
2005-08-17 16:35 ` Tom Rini
2005-08-17 16:27 ` Tom Rini
2005-08-17 11:11 ` Russell King
2005-08-17 16:39 ` David Woodhouse
2005-08-17 16:46 ` Russell King
2005-08-17 14:00 ` When are machine checks suppose to be recoverable? Kumar Gala
2005-08-17 21:44 ` Benjamin Herrenschmidt
2005-08-17 22:30 ` David Woodhouse
2005-08-18 3:42 ` Kumar Gala
2005-08-23 2:56 ` Marcelo Tosatti
2005-08-23 16:43 ` David Woodhouse
2005-08-23 17:04 ` Kumar Gala
2005-08-23 23:10 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050817150536.GN8214@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).