Re: [PATCH] ppc64: Add CONFIG_HZ

Re: [PATCH] ppc64: Add CONFIG_HZ

[Kumar Gala]

Any reason we shouldn't do the same thing on ppc32?

- kumar

On Aug 23, 2005, at 5:53 PM, Anton Blanchard wrote:

>
> Hi,
>
> While ppc64 has the CONFIG_HZ Kconfig option, it wasnt actually being
> used. Connect it up and set all platforms to 250Hz.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
>
> Index: build/include/asm-ppc64/param.h
> ===================================================================
> --- build.orig/include/asm-ppc64/param.h    2005-08-15
> 23:42:07.000000000 +1000
> +++ build/include/asm-ppc64/param.h    2005-08-24 08:02:29.000000000
> +1000
> @@ -1,6 +1,8 @@
>  #ifndef _ASM_PPC64_PARAM_H
>  #define _ASM_PPC64_PARAM_H
>
> +#include <linux/config.h>
> +
>  /*
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU General Public License
> @@ -9,7 +11,7 @@
>   */
>
>  #ifdef __KERNEL__
> -# define HZ        1000        /* Internal kernel timer
> frequency */
> +# define HZ        CONFIG_HZ    /* Internal kernel timer
> frequency */
>  # define USER_HZ    100        /* .. some user interfaces are
> in "ticks" */
>  # define CLOCKS_PER_SEC    (USER_HZ)    /* like times() */
>  #endif
> Index: build/arch/ppc64/configs/g5_defconfig
> ===================================================================
> --- build.orig/arch/ppc64/configs/g5_defconfig    2005-08-15
> 23:42:04.000000000 +1000
> +++ build/arch/ppc64/configs/g5_defconfig    2005-08-24
> 07:55:50.000000000 +1000
> @@ -103,10 +103,10 @@
>  # CONFIG_PREEMPT_VOLUNTARY is not set
>  # CONFIG_PREEMPT is not set
>  # CONFIG_PREEMPT_BKL is not set
> -CONFIG_HZ_100=y
> -# CONFIG_HZ_250 is not set
> +# CONFIG_HZ_100 is not set
> +CONFIG_HZ_250=y
>  # CONFIG_HZ_1000 is not set
> -CONFIG_HZ=100
> +CONFIG_HZ=250
>  CONFIG_GENERIC_HARDIRQS=y
>  CONFIG_SECCOMP=y
>  CONFIG_ISA_DMA_API=y
> Index: build/arch/ppc64/configs/iSeries_defconfig
> ===================================================================
> --- build.orig/arch/ppc64/configs/iSeries_defconfig    2005-08-15
> 23:42:04.000000000 +1000
> +++ build/arch/ppc64/configs/iSeries_defconfig    2005-08-24
> 07:56:46.000000000 +1000
> @@ -94,10 +94,10 @@
>  # CONFIG_PREEMPT_VOLUNTARY is not set
>  # CONFIG_PREEMPT is not set
>  # CONFIG_PREEMPT_BKL is not set
> -CONFIG_HZ_100=y
> -# CONFIG_HZ_250 is not set
> +# CONFIG_HZ_100 is not set
> +CONFIG_HZ_250=y
>  # CONFIG_HZ_1000 is not set
> -CONFIG_HZ=100
> +CONFIG_HZ=250
>  CONFIG_GENERIC_HARDIRQS=y
>  CONFIG_MSCHUNKS=y
>  CONFIG_LPARCFG=y
> Index: build/arch/ppc64/configs/maple_defconfig
> ===================================================================
> --- build.orig/arch/ppc64/configs/maple_defconfig    2005-08-15
> 23:42:04.000000000 +1000
> +++ build/arch/ppc64/configs/maple_defconfig    2005-08-24
> 08:46:58.000000000 +1000
> @@ -103,10 +103,10 @@
>  # CONFIG_PREEMPT_VOLUNTARY is not set
>  # CONFIG_PREEMPT is not set
>  # CONFIG_PREEMPT_BKL is not set
> -CONFIG_HZ_100=y
> -# CONFIG_HZ_250 is not set
> +# CONFIG_HZ_100 is not set
> +CONFIG_HZ_250=y
>  # CONFIG_HZ_1000 is not set
> -CONFIG_HZ=100
> +CONFIG_HZ=250
>  CONFIG_GENERIC_HARDIRQS=y
>  CONFIG_SECCOMP=y
>  CONFIG_ISA_DMA_API=y
> Index: build/arch/ppc64/configs/pSeries_defconfig
> ===================================================================
> --- build.orig/arch/ppc64/configs/pSeries_defconfig    2005-08-15
> 23:42:04.000000000 +1000
> +++ build/arch/ppc64/configs/pSeries_defconfig    2005-08-24
> 07:58:38.000000000 +1000
> @@ -112,10 +112,10 @@
>  # CONFIG_PREEMPT_VOLUNTARY is not set
>  # CONFIG_PREEMPT is not set
>  # CONFIG_PREEMPT_BKL is not set
> -CONFIG_HZ_100=y
> -# CONFIG_HZ_250 is not set
> +# CONFIG_HZ_100 is not set
> +CONFIG_HZ_250=y
>  # CONFIG_HZ_1000 is not set
> -CONFIG_HZ=100
> +CONFIG_HZ=250
>  CONFIG_EEH=y
>  CONFIG_GENERIC_HARDIRQS=y
>  CONFIG_PPC_RTAS=y
> Index: build/arch/ppc64/defconfig
> ===================================================================
> --- build.orig/arch/ppc64/defconfig    2005-08-15 23:42:04.000000000
> +1000
> +++ build/arch/ppc64/defconfig    2005-08-24 07:55:27.000000000 +1000
> @@ -114,10 +114,10 @@
>  # CONFIG_PREEMPT_VOLUNTARY is not set
>  # CONFIG_PREEMPT is not set
>  # CONFIG_PREEMPT_BKL is not set
> -CONFIG_HZ_100=y
> -# CONFIG_HZ_250 is not set
> +# CONFIG_HZ_100 is not set
> +CONFIG_HZ_250=y
>  # CONFIG_HZ_1000 is not set
> -CONFIG_HZ=100
> +CONFIG_HZ=250
>  CONFIG_EEH=y
>  CONFIG_GENERIC_HARDIRQS=y
>  CONFIG_PPC_RTAS=y
> _______________________________________________
> Linuxppc64-dev mailing list
> Linuxppc64-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc64-dev
>

Re: [PATCH] ppc64: Add CONFIG_HZ

[Olof Johansson]

On Fri, Aug 26, 2005 at 02:00:43PM -0500, Kumar Gala wrote:
> Any reason we shouldn't do the same thing on ppc32?

When I built a 2.6.13-rc7 I got the question about what HZ I wanted,
so I guess we're already doing it. Maybe the default needs changing
though, can't remember what it was.


-Olof

Re: [PATCH] ppc64: Add CONFIG_HZ

[Kumar Gala]

What were you building for?  I'm wondering if the same issue exists  
that you are asked, but its not wired to actually do anything.

- kumar

On Aug 26, 2005, at 2:04 PM, Olof Johansson wrote:

> On Fri, Aug 26, 2005 at 02:00:43PM -0500, Kumar Gala wrote:
>
>> Any reason we shouldn't do the same thing on ppc32?
>>
>
> When I built a 2.6.13-rc7 I got the question about what HZ I wanted,
> so I guess we're already doing it. Maybe the default needs changing
> though, can't remember what it was.
>
>
> -Olof
>

Re: [PATCH] ppc64: Add CONFIG_HZ

[Olof Johansson]

On Fri, Aug 26, 2005 at 02:07:37PM -0500, Kumar Gala wrote:
> What were you building for?  I'm wondering if the same issue exists  
> that you are asked, but its not wired to actually do anything.

Doh, you're right. No, it's not wired up. I was building for pmac.


-Olof

Re: [PATCH] ppc64: Add CONFIG_HZ

[Kumar Gala]

On Aug 26, 2005, at 2:14 PM, Olof Johansson wrote:

> On Fri, Aug 26, 2005 at 02:07:37PM -0500, Kumar Gala wrote:
>
>> What were you building for?  I'm wondering if the same issue exists
>> that you are asked, but its not wired to actually do anything.
>>
>
> Doh, you're right. No, it's not wired up. I was building for pmac.

Ok, sent a patch to linuxppc-dev for ppc32 which mimic's Anton's  
patch.  Once we get an include/asm-powerpc going we can merge these  
into on file that lives there.

- kumar