[PATCH] powerpc: don't execute a temporary comment

[PATCH] powerpc: don't execute a temporary comment

[Stephen Rothwell]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---

 arch/ppc/Makefile   |    2 +-
 arch/ppc64/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

86f7688825b1f1e6fa4c43bce001b2a232f7d1bc
diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
--- a/arch/ppc/Makefile
+++ b/arch/ppc/Makefile
@@ -102,9 +102,9 @@ define archhelp
   @echo '  *_defconfig     - Select default config from arch/$(ARCH)/ppc/configs'
 endef
 
+# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
 archclean:
 	$(Q)$(MAKE) $(clean)=arch/ppc/boot
-	# Temporary hack until we have migrated to asm-powerpc
 	$(Q)rm -rf arch/$(ARCH)/include
 
 archprepare: checkbin
diff --git a/arch/ppc64/Makefile b/arch/ppc64/Makefile
--- a/arch/ppc64/Makefile
+++ b/arch/ppc64/Makefile
@@ -113,9 +113,9 @@ defaultimage-$(CONFIG_PPC_ISERIES) := vm
 KBUILD_IMAGE := $(defaultimage-y)
 all: $(KBUILD_IMAGE)
 
+# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
-	# Temporary hack until we have migrated to asm-powerpc
 	$(Q)rm -rf arch/$(ARCH)/include
 
 

Re: [PATCH] powerpc: don't execute a temporary comment

[John W. Linville]

On Thu, Sep 15, 2005 at 04:04:30PM +1000, Stephen Rothwell wrote:

> --- a/arch/ppc/Makefile
> +++ b/arch/ppc/Makefile
> @@ -102,9 +102,9 @@ define archhelp
>    @echo '  *_defconfig     - Select default config from arch/$(ARCH)/ppc/configs'
>  endef
>  
> +# arch/$(ARCH)/include is a temporary hack until we have migrated to asm-powerpc
>  archclean:
>  	$(Q)$(MAKE) $(clean)=arch/ppc/boot
> -	# Temporary hack until we have migrated to asm-powerpc
>  	$(Q)rm -rf arch/$(ARCH)/include
>  
>  archprepare: checkbin

Why is this helpful?  Better in general to keep the commment near the code, no?

John
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] powerpc: don't execute a temporary comment

[Paul Mackerras]

John W. Linville writes:

> Why is this helpful?  Better in general to keep the commment near the code, no?

Where it was, it was a command, not a comment, so it got printed out
on the screen when you did a make clean, which seemed a bit silly.

Paul.

Re: [PATCH] powerpc: don't execute a temporary comment

[Kumar Gala]

We are going to send this to Linus for 2.6.14, right?

- k

On Sep 15, 2005, at 5:55 PM, Paul Mackerras wrote:

> John W. Linville writes:
>
>
>> Why is this helpful?  Better in general to keep the commment near the
>>
> code, no?
>
> Where it was, it was a command, not a comment, so it got printed out
> on the screen when you did a make clean, which seemed a bit silly.
>
> Paul.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>