From: "Mark A. Greer" <mgreer@mvista.com>
To: Corey Minyard <minyard@acm.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: MV64x60 watchdog timer driver updates
Date: Thu, 29 Sep 2005 13:36:47 -0700 [thread overview]
Message-ID: <20050929203647.GA6597@mag.az.mvista.com> (raw)
In-Reply-To: <20050929183221.GA17292@i2.minyard.local>
On Thu, Sep 29, 2005 at 01:32:21PM -0500, Corey Minyard wrote:
> James looked at an earlier version and said it was ok, and suggested
> a few changes. This has been tested against 2.6.14-rc2 on a Katana.
>
> Note that the bus_clk value from the platform information seems to
> be in MHZ, but the actual frequency is generally 133,333,333, not
> 133,000,000. I don't think the inaccuracy matters here, but it seems
> a little odd.
Yes, it makes more sense to me to pass the actual frequency and not do
the '* 1000000'.
Also--I should have thought of this earlier--there should probably be a
patch to add a default platform_data entry in arch/ppc/syslib/mv64x60.c
and a patch for katana.c if the defaults in mv64x60.c aren't correct
for the katana. At least, that's how things are done now.
Mark
next prev parent reply other threads:[~2005-09-29 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 18:32 MV64x60 watchdog timer driver updates Corey Minyard
2005-09-29 20:36 ` Mark A. Greer [this message]
2005-09-30 15:10 ` Corey Minyard
2005-09-30 15:18 ` Geert Uytterhoeven
2005-10-03 20:46 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929203647.GA6597@mag.az.mvista.com \
--to=mgreer@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).