From: Sven Luther <sl@bplan-gmbh.de>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: linuxppc-dev@ozlabs.org, sl@bplan-gmbh.de
Subject: Re: [PATCH 2.6.14-rc3 1/1] chrp_pegasos_eth: Added Marvell Discovery II SRAM support
Date: Fri, 14 Oct 2005 17:18:30 +0200 [thread overview]
Message-ID: <20051014151830.GA31442@localhost.localdomain> (raw)
In-Reply-To: <20051014135641.15104.qmail@xyzzy.farnsworth.org>
On Fri, Oct 14, 2005 at 01:56:41PM -0000, Dale Farnsworth wrote:
> > - static struct pci_device_id pci_marvell_mv64360[] = {
> > + static struct pci_device_id pci_marvell_mv64360[] =
> > + {
>
> > + if (pci_dev_present(pci_marvell_mv64360))
> > + {
>
> Open brace should not be on a line by itself except in function definitions.
Oh, neat, i knew i should not use same-line-braces for function but didn't
know i should use them for non-functions :)
Friendly,
Sven Luther
next prev parent reply other threads:[~2005-10-14 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 20:00 [PATCH 2.6.14-rc3 1/1] chrp_pegasos_eth: Added Marvell Discovery II SRAM support Nicolas DET
2005-10-14 6:50 ` Nicolas DET
2005-10-14 13:56 ` Dale Farnsworth
2005-10-14 15:18 ` Sven Luther [this message]
2005-10-14 21:42 ` Dale Farnsworth
-- strict thread matches above, loose matches on Subject: below --
2005-10-14 17:38 Nicolas DET
2005-10-14 17:45 ` Nicolas DET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051014151830.GA31442@localhost.localdomain \
--to=sl@bplan-gmbh.de \
--cc=dale@farnsworth.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).