From: Brad Boyer <flar@allandria.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] dmasound_pmac depends on pmac specific config options
Date: Sat, 22 Oct 2005 14:01:22 -0700 [thread overview]
Message-ID: <20051022210122.GA9638@pants.nu> (raw)
In-Reply-To: <20051022194626.GA3496@suse.de>
On Sat, Oct 22, 2005 at 09:46:26PM +0200, Olaf Hering wrote:
>
> dmasound_pmac should depend on pmac specific .config options.
> Since PMAC is always defined, but PMAC wont boot without either
> CUDA or PMU, one of these options indicates that the kernel is
> for a PowerMac.
> CONFIG_PM can be selected unconditionally.
I disagree. I think a much better solution would be to change the
code to be conditionalized internally on PMU support, rather than
having #ifdef CONFIG_PM since the functions being called inside
that protection are actually out of the PMU code, not the generic
power management system. By doing this, you could for example
have a kernel compiled for a 1st gen PCI PowerMac without any
extra drivers. In this case, you have CUDA and AWACS, but there
is no PMU support and no need for sleep notifiers.
Similar comments on the other patch.
Brad Boyer
flar@allandria.com
next prev parent reply other threads:[~2005-10-22 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-22 19:46 [PATCH] dmasound_pmac depends on pmac specific config options Olaf Hering
2005-10-22 19:55 ` [PATCH] snd_powermac " Olaf Hering
2005-10-22 21:01 ` Brad Boyer [this message]
2005-10-22 21:19 ` [PATCH] dmasound_pmac " Olaf Hering
2005-10-22 23:03 ` Brad Boyer
2005-10-22 23:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051022210122.GA9638@pants.nu \
--to=flar@allandria.com \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).